Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S967235AbdD0PVc (ORCPT ); Thu, 27 Apr 2017 11:21:32 -0400 Received: from mail-pf0-f194.google.com ([209.85.192.194]:34622 "EHLO mail-pf0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965729AbdD0PVV (ORCPT ); Thu, 27 Apr 2017 11:21:21 -0400 From: Wei Yongjun To: Thomas Gleixner , Jason Cooper , Marc Zyngier , Kefeng Wang Cc: Wei Yongjun , linux-kernel@vger.kernel.org Subject: [PATCH -next] irqchip/mbigen: Fix return value check in mbigen_device_probe() Date: Thu, 27 Apr 2017 15:21:13 +0000 Message-Id: <20170427152113.31147-1-weiyj.lk@gmail.com> X-Mailer: git-send-email 2.9.3 MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 981 Lines: 25 From: Wei Yongjun In case of error, the function devm_ioremap() returns NULL pointer not ERR_PTR(). Use devm_ioremap_resource() instead of devm_ioremap() to fix the IS_ERR() test issue. Fixes: 76e1f77f9c26 ("irqchip/mbigen: Introduce mbigen_of_create_domain()") Signed-off-by: Wei Yongjun --- drivers/irqchip/irq-mbigen.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/irqchip/irq-mbigen.c b/drivers/irqchip/irq-mbigen.c index 061cdb8..d2306c8 100644 --- a/drivers/irqchip/irq-mbigen.c +++ b/drivers/irqchip/irq-mbigen.c @@ -337,8 +337,7 @@ static int mbigen_device_probe(struct platform_device *pdev) mgn_chip->pdev = pdev; res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - mgn_chip->base = devm_ioremap(&pdev->dev, res->start, - resource_size(res)); + mgn_chip->base = devm_ioremap_resource(&pdev->dev, res); if (IS_ERR(mgn_chip->base)) return PTR_ERR(mgn_chip->base);