Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S968651AbdD0PlV convert rfc822-to-8bit (ORCPT ); Thu, 27 Apr 2017 11:41:21 -0400 Received: from mx1.redhat.com ([209.132.183.28]:56240 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937739AbdD0PlO (ORCPT ); Thu, 27 Apr 2017 11:41:14 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 7CF2A8005A Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dhowells@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 7CF2A8005A Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20170427111129.2fe845a3@blatinox-laptop.localdomain> References: <20170427111129.2fe845a3@blatinox-laptop.localdomain> <20170419203819.21951-1-jeremy.lefaure@lse.epita.fr> <28723.1493305425@warthog.procyon.org.uk> To: =?us-ascii?Q?=3D=3FUTF-8=3FB=3FSsOpcsOpbXk=3D=3F=3D?= Lefaure Cc: dhowells@redhat.com, linux-cachefs@redhat.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] FS-Cache: print hexadecimal value for special cookies type MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8BIT Date: Thu, 27 Apr 2017 16:41:10 +0100 Message-ID: <30492.1493307670@warthog.procyon.org.uk> X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.27]); Thu, 27 Apr 2017 15:41:13 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 297 Lines: 13 Jérémy Lefaure wrote: > Did you see the v2 of my patch (in which I keep the decimal value but > fix the buffer size) ? I did. > If special type cookies aren't handled, I guess that this v1 is better, > isn't it ? Yes. v1 is better. The docs are right. David