Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1161916AbdD0SKh (ORCPT ); Thu, 27 Apr 2017 14:10:37 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:41044 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932161AbdD0SK2 (ORCPT ); Thu, 27 Apr 2017 14:10:28 -0400 Date: Thu, 27 Apr 2017 20:10:18 +0200 From: Gerald Schaefer To: Joerg Roedel Cc: Sebastian Ott , iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/2] iommu/s390: Fix iommu-groups and add sysfs support In-Reply-To: <1493306905-32334-1-git-send-email-joro@8bytes.org> References: <1493306905-32334-1-git-send-email-joro@8bytes.org> Organization: IBM Deutschland Research & Development GmbH / Vorsitzende des Aufsichtsrats: Martina Koederitz / Geschaeftsfuehrung: Dirk Wittkopp / Sitz der Gesellschaft: Boeblingen / Registergericht: Amtsgericht Stuttgart, HRB 243294 X-Mailer: Claws Mail 3.9.0 (GTK+ 2.24.23; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17042718-0040-0000-0000-00000397260F X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17042718-0041-0000-0000-00001FE4F616 Message-Id: <20170427201018.70c8be5a@thinkpad> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-27_16:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1704270295 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1273 Lines: 41 On Thu, 27 Apr 2017 17:28:23 +0200 Joerg Roedel wrote: > Hey, > > here are two patches for the s390 PCI and IOMMU code. It is > based on the assumption that every pci_dev that points to > the same zpci_dev shares a single dma-table (and thus a > single address space). Well, there is a separate zpci_dev for each pci_dev on s390, and each of those has its own separate dma-table (thus not shared). > > If this assupmtion is true (as it looks to me from reading > the code) then the iommu-group setup code in the s390 iommu > driver needs to be updated. Given this "separate zpci_dev for each pci_dev" situation, I don't see what this update actually changes, compared to the previous code, see also my comments to that patch. > > These patches do this and also add support for the > iommu_device_register interface to the s390 iommu driver. > > Any comments and testing appreciated. > > Thanks, > > Joerg > > Joerg Roedel (2): > iommu/s390: Fix IOMMU groups > iommu/s390: Add support for iommu_device handling > > arch/s390/include/asm/pci.h | 8 +++++ > arch/s390/pci/pci.c | 10 ++++++- > drivers/iommu/s390-iommu.c | 71 ++++++++++++++++++++++++++++++++++++++------- > 3 files changed, 78 insertions(+), 11 deletions(-) >