Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1164165AbdD0TCv convert rfc822-to-8bit (ORCPT <rfc822;w@1wt.eu>);
        Thu, 27 Apr 2017 15:02:51 -0400
Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:36341 "EHLO
        mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S936434AbdD0TCk (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 27 Apr 2017 15:02:40 -0400
Content-Type: text/plain; charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86
 bzImage
From: Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com>
In-Reply-To: <13470.1493301291@warthog.procyon.org.uk>
Date: Thu, 27 Apr 2017 15:06:34 -0400
Cc: David Woodhouse <dwmw2@infradead.org>,
        keyrings <keyrings@vger.kernel.org>,
        LSM <linux-security-module@vger.kernel.org>,
        kernel <linux-kernel@vger.kernel.org>,
        Mimi Zohar <zohar@linux.vnet.ibm.com>,
        Stefan Berger <stefanb@linux.vnet.ibm.com>,
        George Wilson <gcwilson@us.ibm.com>
Content-Transfer-Encoding: 8BIT
References: <1492727320-26194-4-git-send-email-mkayaalp@linux.vnet.ibm.com>
 <1492727320-26194-1-git-send-email-mkayaalp@linux.vnet.ibm.com>
 <13470.1493301291@warthog.procyon.org.uk>
To: David Howells <dhowells@redhat.com>
X-Mailer: Apple Mail (2.3273)
X-TM-AS-GCONF: 00
x-cbid: 17042719-0052-0000-0000-000001E9A9B1
X-IBM-SpamModules-Scores: 
X-IBM-SpamModules-Versions: BY=3.00006984; HX=3.00000240; KW=3.00000007;
 PH=3.00000004; SC=3.00000208; SDB=6.00853322; UDB=6.00421893; IPR=6.00632162;
 BA=6.00005316; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000;
 ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00015210; XFM=3.00000014;
 UTC=2017-04-27 19:02:38
X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused
x-cbparentid: 17042719-0053-0000-0000-0000504849BD
Message-Id: <73122870-E138-4DA5-90C9-91CB664E7DF1@linux.vnet.ibm.com>
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-27_16:,,
 signatures=0
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0
 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam
 adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000
 definitions=main-1704270308
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 433
Lines: 15


> On Apr 27, 2017, at 9:54 AM, David Howells <dhowells@redhat.com> wrote:
> 
> Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com> wrote:
> 
>> +	/* TODO: update CRC */
> 
> Is this bit missing?

I didn't add it, since I wasn't sure it was still used with secure boot. The CRC 
code is implemented in multiple places, but not exposed to the tools/scripts.
Should I make the crc32() in tools/pcmcia/crc32hash.c non-static, maybe?

Mehmet