Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030905AbdD0TTx (ORCPT ); Thu, 27 Apr 2017 15:19:53 -0400 Received: from vps0.lunn.ch ([178.209.37.122]:43726 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S937348AbdD0TTp (ORCPT ); Thu, 27 Apr 2017 15:19:45 -0400 Date: Thu, 27 Apr 2017 21:19:42 +0200 From: Andrew Lunn To: Vivien Didelot Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@savoirfairelinux.com, "David S. Miller" , Florian Fainelli Subject: Re: [PATCH net-next 09/18] net: dsa: mv88e6xxx: move VTU Data accessors Message-ID: <20170427191942.GL17364@lunn.ch> References: <20170426155336.5937-1-vivien.didelot@savoirfairelinux.com> <20170426155336.5937-10-vivien.didelot@savoirfairelinux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170426155336.5937-10-vivien.didelot@savoirfairelinux.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 689 Lines: 16 On Wed, Apr 26, 2017 at 11:53:27AM -0400, Vivien Didelot wrote: > The code to access the VTU Data registers currently only supports the > 88E6185 family and alike: 2-bit membership adjacent to 2-bit port state. > > Even though the 88E6352 family introduced an indirect table to program > the VLAN Spanning Tree states, the usage of the VTU Data registers > remains the same regardless the VTU or STU operation. > > Now that the mv88e6xxx_vtu_entry structure contains both port membership > and states data, factorize the code to access them in global1_vtu.c. > > Signed-off-by: Vivien Didelot Reviewed-by: Andrew Lunn Andrew