Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1422842AbdD0UVy (ORCPT ); Thu, 27 Apr 2017 16:21:54 -0400 Received: from hr2.samba.org ([144.76.82.148]:20385 "EHLO hr2.samba.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755413AbdD0UVp (ORCPT ); Thu, 27 Apr 2017 16:21:45 -0400 Date: Fri, 28 Apr 2017 06:21:26 +1000 From: Anton Blanchard To: Ankit Kumar Cc: keescook@chromium.org, anton@enomsg.org, ccross@android.com, tony.luck@intel.com, xinhui.pan@linux.vnet.ibm.com, linux-kernel@vger.kernel.org, mahesh@linux.vnet.ibm.com, geliangtang@163.com, paulus@samba.org, andrew.donnellan@au1.ibm.com, linuxppc-dev@lists.ozlabs.org, dja@axtens.net Subject: Re: [PATCH] Enabled pstore write for powerpc Message-ID: <20170428062126.53f80221@kryten> In-Reply-To: <1493292794-13166-1-git-send-email-ankit@linux.vnet.ibm.com> References: <1493292794-13166-1-git-send-email-ankit@linux.vnet.ibm.com> X-Mailer: Claws Mail 3.14.1 (GTK+ 2.24.31; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1218 Lines: 35 Hi Ankit, > After commit c950fd6f201a kernel registers pstore write based on flag > set. Pstore write for powerpc is broken as flags(PSTORE_FLAGS_DMESG) > is not set for powerpc architecture. On panic, kernel doesn't write > message to /fs/pstore/dmesg*(Entry doesn't gets created at all). > > This patch enables pstore write for powerpc architecture by setting > PSTORE_FLAGS_DMESG flag. > > Fixes:c950fd6f201a pstore: Split pstore fragile flags Ouch! We've used pstore to shoot customer bugs, so we should also mark this for stable. Looks like 4.9 onwards? Anton > Signed-off-by: Ankit Kumar > --- > > arch/powerpc/kernel/nvram_64.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/kernel/nvram_64.c > b/arch/powerpc/kernel/nvram_64.c index d5e2b83..021db31 100644 > --- a/arch/powerpc/kernel/nvram_64.c > +++ b/arch/powerpc/kernel/nvram_64.c > @@ -561,6 +561,7 @@ static ssize_t nvram_pstore_read(u64 *id, enum > pstore_type_id *type, static struct pstore_info nvram_pstore_info = { > .owner = THIS_MODULE, > .name = "nvram", > + .flags = PSTORE_FLAGS_DMESG, > .open = nvram_pstore_open, > .read = nvram_pstore_read, > .write = nvram_pstore_write,