Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034943AbdD0Vlx (ORCPT ); Thu, 27 Apr 2017 17:41:53 -0400 Received: from mx0b-001b2d01.pphosted.com ([148.163.158.5]:57215 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754669AbdD0Vlq (ORCPT ); Thu, 27 Apr 2017 17:41:46 -0400 From: Thiago Jung Bauermann To: Mehmet Kayaalp Cc: kbuild test robot , kbuild-all@01.org, LSM , linux-ima-devel@lists.sourceforge.net, keyrings , linux-crypto@vger.kernel.org, kernel , Mimi Zohar , Dmitry Kasatkin , David Howells , Herbert Xu , "David S. Miller" , Claudio Carvalho Subject: Re: [PATCH 6/6] ima: Support appended signatures for appraisal Date: Thu, 27 Apr 2017 18:41:35 -0300 User-Agent: KMail/5.2.3 (Linux/4.4.0-72-generic; KDE/5.28.0; x86_64; ; ) In-Reply-To: References: <201704201148.IPsFhl4B%fengguang.wu@intel.com> <35565259.p7kmk0rNRg@morokweng> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-TM-AS-MML: disable x-cbid: 17042721-0028-0000-0000-000001AF5A60 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17042721-0029-0000-0000-000014AF5ACD Message-Id: <1565385.DQpqeaisNG@morokweng> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-04-27_18:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1703280000 definitions=main-1704270344 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1447 Lines: 31 Am Mittwoch, 26. April 2017, 18:18:34 BRT schrieb Mehmet Kayaalp: > > On Apr 20, 2017, at 7:41 PM, Thiago Jung Bauermann > > wrote: > > > > This patch introduces the appended_imasig keyword to the IMA policy syntax > > to specify that a given hook should expect the file to have the IMA > > signature appended to it. Here is how it can be used in a rule: > > > > appraise func=KEXEC_KERNEL_CHECK appraise_type=appended_imasig > > appraise func=KEXEC_KERNEL_CHECK appraise_type=appended_imasig|imasig > > > > In the second form, IMA will accept either an appended signature or a > > signature stored in the extended attribute. In that case, it will first > > check whether there is an appended signature, and if not it will read it > > from the extended attribute. > > > > The format of the appended signature is the same used for signed kernel > > modules. This means that the file can be signed with the scripts/sign-file > > > tool, with a command line such as this: > I would suggest naming the appraise_type as modsig (or some variant) to > clarify that the format is defined by how module signatures are handled. > Maybe we'd like to define a different appended/inline signature format for > IMA in the future. I like the suggestion. Would that mean that we will keep refering to it as "module signature format", and thus nothing changes in patch 5? -- Thiago Jung Bauermann IBM Linux Technology Center