Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969015AbdD1AVN (ORCPT ); Thu, 27 Apr 2017 20:21:13 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:33618 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938814AbdD1AVA (ORCPT ); Thu, 27 Apr 2017 20:21:00 -0400 Subject: Re: [PATCH 3/7] staging: rtl8723bs: Macros with complex values should be enclosed in parentheses To: Justin Vreeland , gregkh@linuxfoundation.org, hadess@hadess.net References: <20170428001000.7241-1-justin@jvreeland.com> <20170428001000.7241-4-justin@jvreeland.com> Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org From: Larry Finger Message-ID: Date: Thu, 27 Apr 2017 19:20:58 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170428001000.7241-4-justin@jvreeland.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 988 Lines: 28 On 04/27/2017 07:09 PM, Justin Vreeland wrote: > Signed-off-by: Justin Vreeland > --- > drivers/staging/rtl8723bs/hal/odm.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/staging/rtl8723bs/hal/odm.h b/drivers/staging/rtl8723bs/hal/odm.h > index 0b3541a91548..13c4aebd178e 100644 > --- a/drivers/staging/rtl8723bs/hal/odm.h > +++ b/drivers/staging/rtl8723bs/hal/odm.h > @@ -209,7 +209,7 @@ typedef struct _ODM_RATE_ADAPTIVE { > > #define AVG_THERMAL_NUM 8 > #define IQK_Matrix_REG_NUM 8 > -#define IQK_Matrix_Settings_NUM 14+24+21 /* Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */ > +#define IQK_Matrix_Settings_NUM (14+24+21) /* Channels_2_4G_NUM + Channels_5G_20M_NUM + Channels_5G */ You should also put spaces around the plus signs, and fix the lines with more then 80 columns. The comment about non-blank commit messages also applies. Larry > > #define DM_Type_ByFW 0 > #define DM_Type_ByDriver 1 >