Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162864AbdD1BPn (ORCPT ); Thu, 27 Apr 2017 21:15:43 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:46784 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935786AbdD1BPf (ORCPT ); Thu, 27 Apr 2017 21:15:35 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org 340CE61492 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Thu, 27 Apr 2017 18:15:33 -0700 From: Stephen Boyd To: Corentin Labbe Cc: Maxime Ripard , wens@csie.org, mturquette@baylibre.com, linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] clk: sunxi-ng: Fix dependency on SUNXI_CCU_GATE Message-ID: <20170428011533.GZ7065@codeaurora.org> References: <20170426115319.30951-1-clabbe.montjoie@gmail.com> <20170427070436.3qu4mzepq4gmmymi@lukather> <20170427081249.GA25781@Red> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170427081249.GA25781@Red> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1511 Lines: 32 On 04/27, Corentin Labbe wrote: > On Thu, Apr 27, 2017 at 09:04:36AM +0200, Maxime Ripard wrote: > > On Wed, Apr 26, 2017 at 01:53:19PM +0200, Corentin Labbe wrote: > > > When CONFIG_SUNXI_CCU is set but no other SUNXI_CCU is selected i got > > > the following build error: > > > drivers/built-in.o: In function `ccu_pll_notifier_cb': > > > drivers/clk/sunxi-ng/ccu_common.c:71: undefined reference to `ccu_gate_helper_disable' > > > drivers/clk/sunxi-ng/ccu_common.c:73: undefined reference to `ccu_gate_helper_enable' > > > > > > The problem is the function ccu_pll_notifier_cb in ccu_common.c need > > > some function from ccu_gate.c which is not compiled since SUNXI_CCU_GATE > > > is not selected. > > > > > > This patch remove SUNXI_CCU_GATE and compile ccu_gate.c unconditionnaly > > > since all other combination of options select SUNXI_CCU_GATE finally. > > > > > > Fixes: 02ae2bc6febd ("clk: sunxi-ng: Add clk notifier to gate then ungate PLL clocks") > > > Signed-off-by: Corentin Labbe > > > > I think Chen-Yu had some comments that you didn't address. > > > > I have changed subject as requested There were more comments than just fixing the subject. And now Arnd has sent a patch. This is a problem in mainline, and the release is days away. I'm inclined to go with Arnd's patch unless someone sends something else and forward it directly to Linus. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project