Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1034136AbdD1C6C (ORCPT ); Thu, 27 Apr 2017 22:58:02 -0400 Received: from ozlabs.org ([103.22.144.67]:58129 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030299AbdD1C5z (ORCPT ); Thu, 27 Apr 2017 22:57:55 -0400 From: Michael Ellerman To: Kees Cook , Ankit Kumar Cc: Anton Vorontsov , Colin Cross , Tony Luck , Pan Xinhui , "benh\@kernel.crashing.org" , Paul Mackerras , Andrew Donnellan , Daniel Axtens , Geliang Tang , "linuxppc-dev\@lists.ozlabs.org" , LKML , "mahesh\@linux.vnet.ibm.com" Subject: Re: [PATCH] Enabled pstore write for powerpc In-Reply-To: References: <1493292794-13166-1-git-send-email-ankit@linux.vnet.ibm.com> User-Agent: Notmuch/0.21 (https://notmuchmail.org) Date: Fri, 28 Apr 2017 12:57:50 +1000 Message-ID: <8737ctqlw1.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 755 Lines: 19 Kees Cook writes: > On Thu, Apr 27, 2017 at 4:33 AM, Ankit Kumar wrote: >> After commit c950fd6f201a kernel registers pstore write based on flag set. >> Pstore write for powerpc is broken as flags(PSTORE_FLAGS_DMESG) is not set for >> powerpc architecture. On panic, kernel doesn't write message to >> /fs/pstore/dmesg*(Entry doesn't gets created at all). >> >> This patch enables pstore write for powerpc architecture by setting >> PSTORE_FLAGS_DMESG flag. >> >> Fixes:c950fd6f201a pstore: Split pstore fragile flags >> Signed-off-by: Ankit Kumar > > Argh, thanks! I thought I'd caught all of these. I'll include this for -stable. I see you've picked it up, thanks. cheers