Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424412AbdD1Ha5 (ORCPT ); Fri, 28 Apr 2017 03:30:57 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:33139 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424309AbdD1Hav (ORCPT ); Fri, 28 Apr 2017 03:30:51 -0400 MIME-Version: 1.0 In-Reply-To: <20170428072457.GA4911@w540> References: <1493281194-5200-1-git-send-email-jacopo+renesas@jmondi.org> <20170428072457.GA4911@w540> From: Geert Uytterhoeven Date: Fri, 28 Apr 2017 09:30:48 +0200 X-Google-Sender-Auth: DOOggEYhyl1QLw3XFWy7riqhOMk Message-ID: Subject: Re: [PATCH v5 00/10] Renesas RZ/A1 pin and gpio controller To: jmondi Cc: Jacopo Mondi , Linus Walleij , Geert Uytterhoeven , Laurent Pinchart , Chris Brandt , Rob Herring , Mark Rutland , Russell King , Linux-Renesas , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2715 Lines: 76 Hi Jacopo, On Fri, Apr 28, 2017 at 9:24 AM, jmondi wrote: > On Thu, Apr 27, 2017 at 10:42:02AM +0200, Geert Uytterhoeven wrote: >> On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi >> wrote: >> > this is 5th round of gpio/pincontroller for RZ/A1 devices. >> > >> > I have updated the pin controller driver to use the newly introduced >> > "pinctrl_enable()" function. >> > This is required since v4.11-rc7 as otherwise, as reported by Chris Brandt, >> > the pin controller does not start. >> > >> > I have incorporated your comments on the device tree bindings documentation, >> > and added to pinctrl-generic.h header file two macros to unpack generic >> > properties and their arguments. >> > >> > Tested with SCIF, RIIC, ETHER and gpio-leds on Genmai board. >> >> Thanks for the update! >> >> > Jacopo Mondi (10): >> > pinctrl: generic: Add bi-directional and output-enable >> >> Already applied by LinusW. >> >> > pinctrl: generic: Add macros to unpack properties >> >> LinusW: do you want me to queue this together with the driver for v4.13, >> or will you take this single patch for v4.12? >> >> > pinctrl: Renesas RZ/A1 pin and gpio controller >> > dt-bindings: pinctrl: Add RZ/A1 bindings doc >> >> Will queue in sh-pfc-for-v4.13. >> >> > arm: dts: dt-bindings: Add Renesas RZ/A1 pinctrl header >> > arm: dts: r7s72100: Add pin controller node >> > arm: dts: genmai: Add SCIF2 pin group >> > arm: dts: genmai: Add RIIC2 pin group >> > arm: dts: genmai: Add user led device nodes >> > arm: dts: genmai: Add ethernet pin group >> >> These are for Simon. >> >> Does applying the DTS changes before the driver introduce regressions? >> If no, Simon can queue them for v4.13. >> If yes, they'll have to wait for v4.14. >> > > I tried reverting patch [03/10] which introduces the driver, and I > lose serial output on Genmai. So I guess the dts patches have to be > taken after the driver has been merged. > > One question: why can't they be taken at the same time? (eg. for > v4.13?) Because the driver goes in through me and LinusW, while the DTS goes in through Simon and arm-soc. If Simon applies the DTS patches, it will regress genmai in renesas-devel until the release of v4.13-rc1. An immutable branch would solve that, but for adding PFC we usuable just postpone the DT part by one cycle. Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds