Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1163609AbdD1HlL (ORCPT ); Fri, 28 Apr 2017 03:41:11 -0400 Received: from mail-io0-f180.google.com ([209.85.223.180]:36334 "EHLO mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1424515AbdD1Hja (ORCPT ); Fri, 28 Apr 2017 03:39:30 -0400 MIME-Version: 1.0 In-Reply-To: <1493050124-5970-11-git-send-email-rf@opensource.wolfsonmicro.com> References: <1493050124-5970-1-git-send-email-rf@opensource.wolfsonmicro.com> <1493050124-5970-11-git-send-email-rf@opensource.wolfsonmicro.com> From: Linus Walleij Date: Fri, 28 Apr 2017 09:39:21 +0200 Message-ID: Subject: Re: [PATCH v2 10/18] pinctrl: madera: Add driver for Cirrus Logic Madera codecs To: Richard Fitzgerald Cc: Lee Jones , Mark Brown , Alexandre Courbot , Rob Herring , Thomas Gleixner , Jason Cooper , "alsa-devel@alsa-project.org" , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1959 Lines: 43 On Mon, Apr 24, 2017 at 6:08 PM, Richard Fitzgerald wrote: > These codecs have a variable number of I/O lines each of which > is individually selectable to a wide range of possible functions. > > The functionality is slightly different from the traditional muxed > GPIO since most of the functions can be mapped to any pin (and even > the same function to multiple pins). Most pins have a dedicated > "alternate" function that is only available on that pin. The > alternate functions are usually a group of signals, though it is > not always necessary to enable the full group, depending on the > alternate function and how it is to be used. The mapping between > alternate functions and GPIO pins varies between codecs depending > on the number of alternate functions and available pins. > > Note on the Kconfig options: > The formula "default y if..." is used for PINCTRL_MADERA so that its > select options will be processed, allowing us to group selects for > pinctrl into the pinctrl Kconfig where they logically belong instead > of accumulating under the parent MFD Kconfig. > > Signed-off-by: Richard Fitzgerald > --- > Changes since V1: > - dt binding moved to separate patch > - moved all source into a subdirectory drivers/pinctrl/cirrus > - split chip-specific tables into separate files > - codec-specific build options are now selected from MFD > - print useful information from madera_pin_dbg_show() > - added gpio_set_direciton / gpio_request_enable / gpio_disable_free functions > - added strict mode so GPIO and other functions are exclusive > - replace #ifdefs with if (IS_ENABLED(...)) in probe > - fixed bug reading registers in madera_pin_conf_get() Reviewed-by: Linus Walleij I guess you will apply this through MFD, so waiting for Lee to pick it up. Alternatively I can apply it after the MFD core parts are upstream. Yours, Linus Walleij