Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1164899AbdD1Hwz (ORCPT ); Fri, 28 Apr 2017 03:52:55 -0400 Received: from mail.fireflyinternet.com ([109.228.58.192]:49375 "EHLO fireflyinternet.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S966971AbdD1Hws (ORCPT ); Fri, 28 Apr 2017 03:52:48 -0400 X-Default-Received-SPF: pass (skip=forwardok (res=PASS)) x-ip-name=78.156.65.138; Date: Fri, 28 Apr 2017 08:52:33 +0100 From: Chris Wilson To: Kees Cook Cc: linux-kernel@vger.kernel.org, Anton Vorontsov , Colin Cross , Tony Luck , Marta Lofstedt , Namhyung Kim Subject: Re: [PATCH] pstore: Solve lockdep warning by moving inode locks Message-ID: <20170428075233.GI3390@nuc-i3427.alporthouse.com> References: <20170427232037.GA98375@beast> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170427232037.GA98375@beast> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 544 Lines: 14 On Thu, Apr 27, 2017 at 04:20:37PM -0700, Kees Cook wrote: > Lockdep complains about a possible deadlock between mount and unlink > (which is technically impossible), but fixing this improves possible > future multiple-backend support, and keeps locking in the right order. I have merged your for-next/pstore branch (which included this patch, so I hope I chose correctly ;) into our CI. That should exercise it on the machines that we originally found the lockdep splat. Thanks, -Chris -- Chris Wilson, Intel Open Source Technology Centre