Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S939750AbdD1IED (ORCPT <rfc822;w@1wt.eu>);
        Fri, 28 Apr 2017 04:04:03 -0400
Received: from mail-io0-f180.google.com ([209.85.223.180]:33934 "EHLO
        mail-io0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S934706AbdD1IDs (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 28 Apr 2017 04:03:48 -0400
MIME-Version: 1.0
In-Reply-To: <1493198774-4478-8-git-send-email-sean.wang@mediatek.com>
References: <1493198774-4478-1-git-send-email-sean.wang@mediatek.com> <1493198774-4478-8-git-send-email-sean.wang@mediatek.com>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Fri, 28 Apr 2017 10:03:43 +0200
Message-ID: <CACRpkda8bu3zT_kLWSbfx1SobHcQRxEOdJC=PEpW4=+LvcmiMA@mail.gmail.com>
Subject: Re: [PATCH v2 07/30] arm: dts: mt7623: add pinctrl nodes to the
 mt7623 dtsi file
To: sean.wang@mediatek.com
Cc: Rob Herring <robh+dt@kernel.org>,
        Matthias Brugger <matthias.bgg@gmail.com>,
        John Crispin <john@phrozen.org>, Mark Rutland <mark.rutland@arm.com>,
        Russell King <linux@armlinux.org.uk>,
        "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
        "moderated list:ARM/Mediatek SoC support" 
        <linux-mediatek@lists.infradead.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 576
Lines: 20

On Wed, Apr 26, 2017 at 11:25 AM,  <sean.wang@mediatek.com> wrote:

> From: John Crispin <john@phrozen.org>
>
> Add pin controller node to the mt7623.dtsi file
>
> Signed-off-by: John Crispin <john@phrozen.org>
> Signed-off-by: Sean Wang <sean.wang@mediatek.com>
(...)
> +       pio: pinctrl@10005000 {
> +               compatible = "mediatek,mt7623-pinctrl",
> +                            "mediatek,mt2701-pinctrl";

This looks right. And that is why we should not delete that compatible
string.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij