Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969259AbdD1IvL (ORCPT ); Fri, 28 Apr 2017 04:51:11 -0400 Received: from mail-it0-f51.google.com ([209.85.214.51]:37299 "EHLO mail-it0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1425021AbdD1Itj (ORCPT ); Fri, 28 Apr 2017 04:49:39 -0400 MIME-Version: 1.0 In-Reply-To: <1493281194-5200-11-git-send-email-jacopo+renesas@jmondi.org> References: <1493281194-5200-1-git-send-email-jacopo+renesas@jmondi.org> <1493281194-5200-11-git-send-email-jacopo+renesas@jmondi.org> From: Linus Walleij Date: Fri, 28 Apr 2017 10:49:32 +0200 Message-ID: Subject: Re: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group To: Jacopo Mondi Cc: Geert Uytterhoeven , Laurent Pinchart , Chris Brandt , Rob Herring , Mark Rutland , Russell King , Linux-Renesas , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 706 Lines: 23 On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi wrote: > Add pin configuration subnode for ETHER ethernet controller. > > Signed-off-by: Jacopo Mondi (...) > + pins_bidir { > + pinmux = ;/* P3_3 = ET_MDIO */ > + bi-directional; > + }; So I'm against merging this until someone explains what "bi-directional" actually means, electrically speaking. What happens physically on this pin? I think this just means open drain. It is dangerous to merge things we don't understand. Surely someone inside Renesas can answer this question. Yours, Linus Walleij