From: "Lofstedt, Marta" <marta.lofstedt@intel.com>
To: Chris Wilson <chris@chris-wilson.co.uk>,
        Kees Cook <keescook@chromium.org>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Anton Vorontsov" <anton@enomsg.org>, Colin Cross <ccross@android.com>,
        "Luck, Tony" <tony.luck@intel.com>, Namhyung Kim <namhyung@kernel.org>
Subject: RE: [PATCH] pstore: Solve lockdep warning by moving inode locks
Thread-Topic: [PATCH] pstore: Solve lockdep warning by moving inode locks
Thread-Index: AQHSv6z0E1GHq1Vv+k6AN71cJXaIqaHaWKyAgAAfxvA=
Date: Fri, 28 Apr 2017 09:00:32 +0000
Message-ID: <CA5F6A4B62957246A9595641974606435968466A@IRSMSX106.ger.corp.intel.com>
References: <20170427232037.GA98375@beast>
 <20170428075233.GI3390@nuc-i3427.alporthouse.com>
In-Reply-To: <20170428075233.GI3390@nuc-i3427.alporthouse.com>
Accept-Language: en-US
Content-Language: en-US
dlp-product: dlpe-windows
dlp-version: 10.0.102.7
dlp-reaction: no-action
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1571
Lines: 37


> -----Original Message-----
> From: Chris Wilson [mailto:chris@chris-wilson.co.uk]
> Sent: Friday, April 28, 2017 10:53 AM
> To: Kees Cook <keescook@chromium.org>
> Cc: linux-kernel@vger.kernel.org; Anton Vorontsov <anton@enomsg.org>;
> Colin Cross <ccross@android.com>; Luck, Tony <tony.luck@intel.com>;
> Lofstedt, Marta <marta.lofstedt@intel.com>; Namhyung Kim
> <namhyung@kernel.org>
> Subject: Re: [PATCH] pstore: Solve lockdep warning by moving inode locks
> 
> On Thu, Apr 27, 2017 at 04:20:37PM -0700, Kees Cook wrote:
> > Lockdep complains about a possible deadlock between mount and unlink
> > (which is technically impossible), but fixing this improves possible
> > future multiple-backend support, and keeps locking in the right order.
> 
> I have merged your for-next/pstore branch (which included this patch, so I
> hope I chose correctly ;) into our CI. That should exercise it on the machines
> that we originally found the lockdep splat.
> 
> Thanks,
> -Chris
> 

Chris, I tested this on drm-tip after you merged for-next/pstore. 
EFI_VARS_PSTORE is enabled. 
I deliberately cause kernel panic and reboot, but unfortunately that kernel doesn't reboot properly. On display I see a bunch of:
"Cleaning orphaned inode ...", but then kernel boot  is stuck. 
I run this on a BDW NUCi5, which I have been using successfully with pstore-efi for weeks. 
Fortunately I had some other pstore enabled kernels, so if I clean out /sys/fs/pstore/* with one of them I can boot above kernel again.

BR,
Marta

> --
> Chris Wilson, Intel Open Source Technology Centre