Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425483AbdD1JRI (ORCPT ); Fri, 28 Apr 2017 05:17:08 -0400 Received: from mx2.suse.de ([195.135.220.15]:46180 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1425402AbdD1JPE (ORCPT ); Fri, 28 Apr 2017 05:15:04 -0400 Subject: Re: [PATCH v2] ceph: Fix file open flags on ppc64 To: "Yan, Zheng" References: <1493310840-201351-1-git-send-email-agraf@suse.de> Cc: ceph-devel , Sage Weil , Ilya Dryomov , Linux Kernel Mailing List , Jan.Fajerski@suse.com, Jeff Layton From: Alexander Graf Message-ID: <56b605cc-ee88-612e-4935-a60a3a151f04@suse.de> Date: Fri, 28 Apr 2017 11:14:56 +0200 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.12; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 841 Lines: 27 On 28.04.17 09:57, Yan, Zheng wrote: > >> On 28 Apr 2017, at 00:34, Alexander Graf wrote: >> >> The file open flags (O_foo) are platform specific and should never go >> out to an interface that is not local to the system. >> >> Unfortunately these flags have leaked out onto the wire in the cephfs >> implementation. That lead to bogus flags getting transmitted on ppc64. >> >> This patch converts the kernel view of flags to the ceph view of file >> open flags. >> >> Fixes: 124e68e74 ("ceph: file operations") >> Signed-off-by: Alexander Graf >> >> — > > I removed the "unused open flags” dout and applied the patch. Thank you for tracking down and fixing the bug. I actually put that in on purpose, in case anyone in 2 years tries to find out why a particular flag doesn't get populated :). Alex