DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 577CC4E4D0
Content-Type: text/plain; charset=utf-8
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH v2] ceph: Fix file open flags on ppc64
From: "Yan, Zheng" <zyan@redhat.com>
In-Reply-To: <56b605cc-ee88-612e-4935-a60a3a151f04@suse.de>
Date: Fri, 28 Apr 2017 17:23:46 +0800
Cc: ceph-devel <ceph-devel@vger.kernel.org>, Sage Weil <sage@redhat.com>,
        Ilya Dryomov <idryomov@gmail.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Jan.Fajerski@suse.com, Jeff Layton <jlayton@redhat.com>
Content-Transfer-Encoding: 8BIT
Message-Id: <414E884C-2A35-40D5-858D-2F05D67C9CA5@redhat.com>
References: <1493310840-201351-1-git-send-email-agraf@suse.de>
 <D29AEA6E-CB75-42CF-A0B6-47F61A23183C@redhat.com>
 <56b605cc-ee88-612e-4935-a60a3a151f04@suse.de>
To: Alexander Graf <agraf@suse.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 996
Lines: 34


> On 28 Apr 2017, at 17:14, Alexander Graf <agraf@suse.de> wrote:
> 
> 
> 
> On 28.04.17 09:57, Yan, Zheng wrote:
>> 
>>> On 28 Apr 2017, at 00:34, Alexander Graf <agraf@suse.de> wrote:
>>> 
>>> The file open flags (O_foo) are platform specific and should never go
>>> out to an interface that is not local to the system.
>>> 
>>> Unfortunately these flags have leaked out onto the wire in the cephfs
>>> implementation. That lead to bogus flags getting transmitted on ppc64.
>>> 
>>> This patch converts the kernel view of flags to the ceph view of file
>>> open flags.
>>> 
>>> Fixes: 124e68e74 ("ceph: file operations")
>>> Signed-off-by: Alexander Graf <agraf@suse.de>
>>> 
>>> —
>> 
>> I removed the "unused open flags” dout and applied the patch. Thank you for tracking down and fixing the bug.
> 
> I actually put that in on purpose, in case anyone in 2 years tries to find out why a particular flag doesn't get populated :).
> 
Ok, I will put it back.

Regards
Yan, Zheng

> 
> Alex