Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1424164AbdD1Kr1 (ORCPT ); Fri, 28 Apr 2017 06:47:27 -0400 Received: from mail-eopbgr10073.outbound.protection.outlook.com ([40.107.1.73]:55328 "EHLO EUR02-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754805AbdD1KrS (ORCPT ); Fri, 28 Apr 2017 06:47:18 -0400 From: =?iso-8859-2?Q?Horia_Geant=E3?= To: Greg KH CC: Roy Pledge , "devel@driverdev.osuosl.org" , Stuart Yoder , "linux-kernel@vger.kernel.org" , Haiying Wang Subject: Re: [PATCH v2] bus: fsl-mc: dpio: fix alter FQ state command Thread-Topic: [PATCH v2] bus: fsl-mc: dpio: fix alter FQ state command Thread-Index: AQHSwAqvHUEaTWSSjkCNo46SX6ml3Q== Date: Fri, 28 Apr 2017 10:47:14 +0000 Message-ID: References: <20170421144734.7nr2dnqcltgov74v@mwanda> <20170422064449.25498-1-horia.geanta@nxp.com> <20170428103154.GA27623@kroah.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: spf=none (sender IP is ) smtp.mailfrom=horia.geanta@nxp.com; x-originating-ip: [192.88.146.1] x-microsoft-exchange-diagnostics: 1;VI1PR0401MB2558;7:7m+Uyk4xTzqisbs5v5YC1Jd9BaRgHES1vtGf7BODvehsbuv2lySKmX5tVm8PoDA6AoFqj4UJKTCKt8P93ZXrS9JnU4e04xJuv8J/Avox9IkQcXpKKv86tNbLzAHChTJqjNFnlr076g9FVu103oygiXZ/5ThtwHeQY8eHEJ8VkO+8o7P8IFmeOSjdKX6ysrObe3JGI3iVTj/iyyivDFFHLEh4kaRZbGzItvdvR/GZdWti485qU+e+yB3tHbBEjipx/82xB1f3lfTau2IHNK7j97Xm3TffYbUUdQRRyeSttLQ/xHF66S2+zpw7lzgNzIwLXTDRC2aKMHD3Ih30JlnXwA== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39450400003)(39400400002)(39850400002)(39840400002)(39860400002)(377454003)(24454002)(3846002)(102836003)(86362001)(6116002)(6246003)(50986999)(110136004)(38730400002)(33656002)(66066001)(39060400002)(76176999)(8936002)(54356999)(81166006)(8676002)(5660300001)(2900100001)(122556002)(229853002)(54906002)(3280700002)(3660700001)(99286003)(55016002)(9686003)(53936002)(2906002)(6506006)(6436002)(77096006)(6916009)(189998001)(4326008)(25786009)(53546009)(7736002)(74316002)(305945005)(7696004);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB2558;H:VI1PR0401MB2591.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; x-ms-office365-filtering-correlation-id: 3ffe64a4-7b46-47ed-ee93-08d48e23eea6 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:VI1PR0401MB2558; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197)(275809806118684); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(5005006)(8121501046)(3002001)(93006095)(93001095)(10201501046)(6055026)(6041248)(20161123564025)(20161123555025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(6072148);SRVR:VI1PR0401MB2558;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB2558; x-forefront-prvs: 029174C036 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-2" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2017 10:47:14.3498 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2558 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v3SAlcmw019313 Content-Length: 1070 Lines: 27 On 4/28/2017 1:32 PM, Greg KH wrote: > On Sat, Apr 22, 2017 at 09:44:49AM +0300, Horia Geant? wrote: >> When checking the response verb, the valid bit should be masked out, >> since its value flips depending on what Response Register >> (RR0 /RR1) it's been read from. >> >> Fixes: 321eecb06bfb ("bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2") >> Signed-off-by: Horia Geant? >> --- >> v2: use QBMAN_RESULT_MASK instead of hard-coded mask > > Why are you not using 'staging' in your subject line? > I was not aware this is required and followed the statistics: git log --oneline drivers/staging/fsl-mc/bus/dpio/ 141a10aead9c staging: fsl-mc/dpio: Fix early writing of valid bit 993fec7e11ca bus: fsl-mc: dpio: add the DPAA2 DPIO object driver 780b626323d7 bus: fsl-mc: dpio: add the DPAA2 DPIO service interface 321eecb06bfb bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2 2704aedb5c21 bus: fsl-mc: dpio: add APIs for DPIO objects 0e6437941e44 bus: fsl-mc: dpio: add DPIO driver overview document Do I have to resubmit? Thanks, Horia