Message-ID: <1493381857.14233.23.camel@coelho.fi>
From: Luca Coelho <luca@coelho.fi>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: gregkh@linuxfoundation.org, wagi@monom.org, dwmw2@infradead.org,
        rafal@milecki.pl, arend.vanspriel@broadcom.com, rjw@rjwysocki.net,
        yi1.li@linux.intel.com, atull@opensource.altera.com,
        moritz.fischer@ettus.com, pmladek@suse.com, johannes.berg@intel.com,
        emmanuel.grumbach@intel.com, kvalo@codeaurora.org, luto@kernel.org,
        takahiro.akashi@linaro.org, dhowells@redhat.com, pjones@redhat.com,
        linux-kernel@vger.kernel.org
Date: Fri, 28 Apr 2017 15:17:37 +0300
In-Reply-To: <20170428005615.GN28800@wotan.suse.de>
References: <20170330032514.17173-1-mcgrof@kernel.org>
         <20170330032514.17173-5-mcgrof@kernel.org>
         <1491830352.31980.52.camel@coelho.fi>
         <20170428005615.GN28800@wotan.suse.de>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Subject: Re: [PATCH v6 4/5] iwlwifi: convert to use driver data API
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1709
Lines: 50

On Fri, 2017-04-28 at 02:56 +0200, Luis R. Rodriguez wrote:
> On Mon, Apr 10, 2017 at 04:19:12PM +0300, Luca Coelho wrote:
> > On Wed, 2017-03-29 at 20:25 -0700, Luis R. Rodriguez wrote:
> > > The driver data API provides support for looking for firmware
> > > from a specific set of API ranges, so just use that. Since we
> > > free the firmware on the callback immediately after consuming it,
> > > this also takes avantage of that feature.
> > > 
> > > Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> > > ---
> > 
> > Looks fine, with one nitpick.
> > 
> > 
> > >  drivers/net/wireless/intel/iwlwifi/iwl-drv.c | 67 ++++++++++------------------
> > >  1 file changed, 23 insertions(+), 44 deletions(-)
> > > 
> > > diff --git a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
> > > index be466a074c1d..b6643aa5b344 100644
> > > --- a/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
> > > +++ b/drivers/net/wireless/intel/iwlwifi/iwl-drv.c
> > 
> > [...]
> > 
> > > @@ -1541,11 +1522,9 @@ struct iwl_drv *iwl_drv_start(struct iwl_trans *trans)
> > >  	}
> > >  #endif
> > >  
> > > -	ret = iwl_request_firmware(drv, true);
> > > -	if (ret) {
> > > -		IWL_ERR(trans, "Couldn't request the fw\n");
> > > +	ret = iwl_request_firmware(drv);
> > > +	if (ret)
> > >  		goto err_fw;
> > > -	}
> > 
> > Why remove the error message here?
> 
> The driver data API now has enough semantics even for async requests so that
> an error is either always issued or supressed (optional is true), driver errors
> then are superfluous on error now.
> 
> Let me know if this is OK.

Yeah, that's okay.  We can always add something back if we think it's
needed.

--
Cheers,
Luca.