Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756637AbdD1MWe (ORCPT ); Fri, 28 Apr 2017 08:22:34 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:43058 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755494AbdD1MW1 (ORCPT ); Fri, 28 Apr 2017 08:22:27 -0400 Date: Fri, 28 Apr 2017 14:22:17 +0200 From: Greg KH To: Horia =?utf-8?Q?Geant=C4=83?= Cc: Roy Pledge , "devel@driverdev.osuosl.org" , Stuart Yoder , "linux-kernel@vger.kernel.org" , Haiying Wang Subject: Re: [PATCH v2] bus: fsl-mc: dpio: fix alter FQ state command Message-ID: <20170428122217.GA18081@kroah.com> References: <20170421144734.7nr2dnqcltgov74v@mwanda> <20170422064449.25498-1-horia.geanta@nxp.com> <20170428103154.GA27623@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.8.2 (2017-04-18) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1280 Lines: 32 On Fri, Apr 28, 2017 at 10:47:14AM +0000, Horia Geantă wrote: > On 4/28/2017 1:32 PM, Greg KH wrote: > > On Sat, Apr 22, 2017 at 09:44:49AM +0300, Horia Geantă wrote: > >> When checking the response verb, the valid bit should be masked out, > >> since its value flips depending on what Response Register > >> (RR0 /RR1) it's been read from. > >> > >> Fixes: 321eecb06bfb ("bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2") > >> Signed-off-by: Horia Geantă > >> --- > >> v2: use QBMAN_RESULT_MASK instead of hard-coded mask > > > > Why are you not using 'staging' in your subject line? > > > I was not aware this is required and followed the statistics: > > git log --oneline drivers/staging/fsl-mc/bus/dpio/ > 141a10aead9c staging: fsl-mc/dpio: Fix early writing of valid bit > 993fec7e11ca bus: fsl-mc: dpio: add the DPAA2 DPIO object driver > 780b626323d7 bus: fsl-mc: dpio: add the DPAA2 DPIO service interface > 321eecb06bfb bus: fsl-mc: dpio: add QBMan portal APIs for DPAA2 > 2704aedb5c21 bus: fsl-mc: dpio: add APIs for DPIO objects > 0e6437941e44 bus: fsl-mc: dpio: add DPIO driver overview document > > Do I have to resubmit? No, I have edited the subject, it should be "staging: fsl-mc: bus: ..." for future patches. thanks, greg k-h