Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S264690AbTFEOOe (ORCPT ); Thu, 5 Jun 2003 10:14:34 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S264691AbTFEOOe (ORCPT ); Thu, 5 Jun 2003 10:14:34 -0400 Received: from griffon.mipsys.com ([217.167.51.129]:34014 "EHLO gaston") by vger.kernel.org with ESMTP id S264690AbTFEOOd (ORCPT ); Thu, 5 Jun 2003 10:14:33 -0400 Subject: Re: [PATCH] IDE Power Management, try 2 From: Benjamin Herrenschmidt To: Bartlomiej Zolnierkiewicz Cc: Alan Cox , Jens Axboe , linux-kernel mailing list In-Reply-To: References: Content-Type: text/plain Content-Transfer-Encoding: 7bit Organization: Message-Id: <1054823279.765.14.camel@gaston> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.2.4 Date: 05 Jun 2003 16:27:59 +0200 Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 661 Lines: 20 > > I had to add yet another rq->flags bit for that, and I think that sucks > > You don't have if you use additional, default pm_state (on == 0). > This sucks too, but a bit less. Can you elaborate ? I'm not sure I understand what you meant > I think extending struct request is the way to go, > pm_step & pm_state or even pointer to rq_pm_struct. Ok. I'll wait for Jens ack and go that way if he agrees. Ben. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/