Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1425990AbdD1NSS (ORCPT ); Fri, 28 Apr 2017 09:18:18 -0400 Received: from relmlor4.renesas.com ([210.160.252.174]:8702 "EHLO relmlie3.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1425945AbdD1NSO (ORCPT ); Fri, 28 Apr 2017 09:18:14 -0400 X-IronPort-AV: E=Sophos;i="5.37,388,1488812400"; d="scan'208";a="242138685" From: Chris Brandt To: Andy Shevchenko CC: Linus Walleij , Jacopo Mondi , Geert Uytterhoeven , Laurent Pinchart , Rob Herring , Mark Rutland , "Russell King - ARM Linux" , Linux-Renesas , "linux-gpio@vger.kernel.org" , devicetree , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable Thread-Topic: [PATCH v5 01/10] pinctrl: generic: Add bi-directional and output-enable Thread-Index: AQHSvy8kW/T8jbNXV0G/jE8WsCEqd6HZTneAgAEnEICAACrhkIAAE36AgAAKEjA= Date: Fri, 28 Apr 2017 13:18:06 +0000 Message-ID: References: <1493281194-5200-1-git-send-email-jacopo+renesas@jmondi.org> <1493281194-5200-2-git-send-email-jacopo+renesas@jmondi.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=renesas.com; x-originating-ip: [75.60.247.61] x-microsoft-exchange-diagnostics: 1;SG2PR06MB1168;7:pmP+yjAcXnbjk9G+aVcbadeQlDN13rRH7kzOoAJ+fYVZiMmmEtV5uB7PvZGonrTn0iUJd5Y/nXEqPPvvYQWeF/IoeP6ReGvWCtTRrPURXrJqtUJXtO+ujisgJRaBiDad2M5M6imusW4nyFn1ZOk6l27XJnq9lOX7yu/sOHiCw/EZOO7NrqQQzUcwNfGdRQK2H8+zHqSNfq9vDmzaS+WeJjOYFxia5LEgE6RagKq8xx5NY80ct495TEf7lkg70GphLXSmkxKUUmhlyYNpaP04UifEPHr2IoB38hriCY9GHgtgsxCM6AphLAXbwNaEpQEgRCYidgC+6UpQkU4NFbaVnw==;20:HEA2oupsMYs8YRqsk5jzqmBJiSvNeA3LjEEkxEg5rGUGnyPlRATDcgoBaG2H41MzgnWc6pht6IUngcFyGdBrSBiZK/qPrtsEKUVDvoMCT/+h6r58BjivYDZ0nA01vLa9098K1XIvodEMj+ua+7sjc1OFQQ6aXYDmxM8MnYioY8w= x-ms-office365-filtering-correlation-id: 5228e882-d8b2-4c47-3d39-08d48e390215 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:SG2PR06MB1168; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(93006095)(93001095)(3002001)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(20161123564025)(20161123562025)(20161123555025)(6072148);SRVR:SG2PR06MB1168;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB1168; x-forefront-prvs: 029174C036 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39450400003)(39410400002)(39400400002)(39850400002)(39860400002)(39840400002)(85664002)(24454002)(86362001)(2906002)(25786009)(77096006)(3280700002)(50986999)(76176999)(7416002)(3660700001)(33656002)(54356999)(6246003)(74316002)(4326008)(7696004)(2900100001)(6116002)(3846002)(102836003)(2950100002)(6916009)(93886004)(110136004)(53936002)(189998001)(9686003)(99286003)(54906002)(5660300001)(8936002)(55016002)(8676002)(229853002)(6306002)(81166006)(38730400002)(6436002)(7736002)(6506006)(122556002)(66066001)(39060400002)(305945005)(41533002);DIR:OUT;SFP:1102;SCL:1;SRVR:SG2PR06MB1168;H:SG2PR06MB1165.apcprd06.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2017 13:18:06.3056 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB1168 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3SDITpm026755 Content-Length: 1866 Lines: 39 On Friday, April 28, 2017, Andy Shevchenko wrote: > > In the RZ/A1 HW manual you can kind of see that in 54.18 Port Control > Logical Diagram (but that wasn't obvious to me at first). > > Please, post a link to it or copy essential parts. This board the RZ/A1 GENMAI board. https://www.renesas.com/en-us/products/software-tools/boards-and-kits/evaluation-demo-solution-boards/genmai-cpu-board-rtk772100bc00000br.html The schematic is included in the "User's manual" https://www.renesas.com/en-us/doc/products/tool/doc/003/r20ut2596ej_r7s72100evum.pdf The RZ/A1H Hardware manual is here: https://www.renesas.com/en-us/document/hw-manual?hwLayerShowFlg=true&prdLayerId=186374&layerName=RZ%252FA1H&coronrService=document-prd-search&hwDocUrl=%2Fen-us%2Fdoc%2Fproducts%2Fmpumcu%2Fdoc%2Frz%2Fr01uh0403ej0300_rz_a1h.pdf&hashKey=54f335753742b5add524d4725b7242e6 Chapter 54 is the port/pin controller. "54.18 Port Control Logical Diagram" is the diagram I was talking about. Note that is says "Note: This figure shows the logic for reference, not the circuit." "54.3.13 Port Bidirection Control Register (PBDCn)" is the magic register needed to get some pins to work. > I'm quite skeptical that cheap hardware can implement something more > costable than simplest open-source / open-drain + bias I don't think this is an open-source / open-drain + bias issue. It's a "the internal signal paths are not getting hooked up correctly" issue. Regardless, on this part, we needed a way to flag that some pins when put in some function modes needed 'an extra register setting'. At first we tried to sneak that info in with a simple #define in the pin/pinmux DT node properties. But, Linus didn't want it there so we had to make up a new generic property called "bi-directional". What is your end goal here? Get "bi-directional" changed to something else? Chris