Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426035AbdD1Nl3 (ORCPT ); Fri, 28 Apr 2017 09:41:29 -0400 Received: from mail-io0-f194.google.com ([209.85.223.194]:35455 "EHLO mail-io0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1423535AbdD1NlW (ORCPT ); Fri, 28 Apr 2017 09:41:22 -0400 Date: Fri, 28 Apr 2017 08:41:20 -0500 From: Rob Herring To: William Wu Cc: balbi@kernel.org, gregkh@linuxfoundation.org, heiko@sntech.de, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org, frank.wang@rock-chips.com, huangtao@rock-chips.com, dianders@google.com, briannorris@google.com, groeck@google.com, daniel.meng@rock-chips.com, John.Youn@synopsys.com Subject: Re: [PATCH v3] usb: dwc3: add disable u2mac linestate check quirk Message-ID: <20170428134120.deqjesvinuoskem7@rob-hp-laptop> References: <1492603898-25070-1-git-send-email-william.wu@rock-chips.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1492603898-25070-1-git-send-email-william.wu@rock-chips.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1283 Lines: 32 On Wed, Apr 19, 2017 at 08:11:38PM +0800, William Wu wrote: > This patch adds a quirk to disable USB 2.0 MAC linestate check > during HS transmit. Refer the dwc3 databook, we can use it for > some special platforms if the linestate not reflect the expected > line state(J) during transmission. > > When use this quirk, the controller implements a fixed 40-bit > TxEndDelay after the packet is given on UTMI and ignores the > linestate during the transmit of a token (during token-to-token > and token-to-data IPGAP). > > On some rockchip platforms (e.g. rk3399), it requires to disable > the u2mac linestate check to decrease the SSPLIT token to SETUP > token inter-packet delay from 566ns to 466ns, and fix the issue > that FS/LS devices not recognized if inserted through USB 3.0 HUB. > > Signed-off-by: William Wu > --- > Changes in v3: > - change quirk name > - only read and write GUCTL1 if dwc3 version >= 2.50a > > Changes in v2: > - fix coding style > > Documentation/devicetree/bindings/usb/dwc3.txt | 2 ++ Acked-by: Rob Herring > drivers/usb/dwc3/core.c | 20 ++++++++++++++------ > drivers/usb/dwc3/core.h | 4 ++++ > 3 files changed, 20 insertions(+), 6 deletions(-)