Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1165565AbdD1NwD (ORCPT ); Fri, 28 Apr 2017 09:52:03 -0400 Received: from smtp-out4.electric.net ([192.162.216.191]:53314 "EHLO smtp-out4.electric.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933285AbdD1Nvy (ORCPT ); Fri, 28 Apr 2017 09:51:54 -0400 From: David Laight To: "'Sabrina Dubroca'" , Ding Tianhong CC: David Miller , "pabeni@redhat.com" , "edumazet@google.com" , "hannes@stressinduktion.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , LinuxArm Subject: RE: [PATCH] iov_iter: don't revert if csum error Thread-Topic: [PATCH] iov_iter: don't revert if csum error Thread-Index: AQHSwCG0WyGUzcwfdUKbKLaFJ3f8I6HazKCA Date: Fri, 28 Apr 2017 13:51:43 +0000 Message-ID: <063D6719AE5E284EB5DD2968C1650D6DCFFE1464@AcuExch.aculab.com> References: <080dafec-c57f-0546-4d2f-ce4a31222e25@huawei.com> <20170428131631.GA22996@bistromath.localdomain> In-Reply-To: <20170428131631.GA22996@bistromath.localdomain> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.202.99.200] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-Outbound-IP: 213.249.233.130 X-Env-From: David.Laight@ACULAB.COM X-Proto: esmtps X-Revdns: X-HELO: AcuExch.aculab.com X-TLS: TLSv1:AES128-SHA:128 X-Authenticated_ID: X-PolicySMART: 3396946, 3397078 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3SDqH87030378 Content-Length: 330 Lines: 14 From: Sabrina Dubroca > Sent: 28 April 2017 14:17 ... > > if (__skb_checksum_complete(skb)) > > - goto csum_error; > > + goto fault; > > With this patch, skb_copy_and_csum_datagram_msg() will return -EFAULT > for an incorrect checksum, that doesn't seem right. Especially since (IIRC) -EFAULT generates SIGSEGV. David