Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1162699AbdD1O1i (ORCPT ); Fri, 28 Apr 2017 10:27:38 -0400 Received: from mail-it0-f51.google.com ([209.85.214.51]:37149 "EHLO mail-it0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939316AbdD1O1b (ORCPT ); Fri, 28 Apr 2017 10:27:31 -0400 Date: Fri, 28 Apr 2017 08:27:28 -0600 From: Jens Axboe To: Dan Williams Cc: linux-block@vger.kernel.org, Vishal Verma , Christoph Hellwig , "Martin K. Petersen" , linux-kernel@vger.kernel.org Subject: Re: [PATCH] block: hide badblocks attribute by default Message-ID: <20170428142727.GA15489@kernel.dk> References: <149332958627.40858.3562179022452904734.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <149332958627.40858.3562179022452904734.stgit@dwillia2-desk3.amr.corp.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 461 Lines: 12 On Thu, Apr 27 2017, Dan Williams wrote: > Commit 99e6608c9e74 "block: Add badblock management for gendisks" > allowed for drivers like pmem and software-raid to advertise a list of > bad media areas. However, it inadvertently added a 'badblocks' to all > block devices. Lets clean this up by having the 'badblocks' attribute > not be visible when the driver has not populated a 'struct badblocks' > instance in the gendisk. Thanks Dan, added. -- Jens Axboe