Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2998575AbdD1Otc (ORCPT ); Fri, 28 Apr 2017 10:49:32 -0400 Received: from relmlor3.renesas.com ([210.160.252.173]:53147 "EHLO relmlie2.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1426221AbdD1Os7 (ORCPT ); Fri, 28 Apr 2017 10:48:59 -0400 X-IronPort-AV: E=Sophos;i="5.37,388,1488812400"; d="scan'208";a="241245295" From: Chris Brandt To: Geert Uytterhoeven CC: Jacopo Mondi , Linus Walleij , Geert Uytterhoeven , Laurent Pinchart , Rob Herring , Mark Rutland , Russell King , Linux-Renesas , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group Thread-Topic: [PATCH v5 10/10] arm: dts: genmai: Add ethernet pin group Thread-Index: AQHSvy9EURq5AGyGDkyOQ4Jftj1YPqHY+r2AgAAM2KCAAVlgAIAAblTQ Date: Fri, 28 Apr 2017 14:48:52 +0000 Message-ID: References: <1493281194-5200-1-git-send-email-jacopo+renesas@jmondi.org> <1493281194-5200-11-git-send-email-jacopo+renesas@jmondi.org> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: linux-m68k.org; dkim=none (message not signed) header.d=none;linux-m68k.org; dmarc=none action=none header.from=renesas.com; x-originating-ip: [75.60.247.61] x-microsoft-exchange-diagnostics: 1;SG2PR06MB1166;7:2fdpDaskS9a6rIaJVAoebkSYnAoHgiwoV5QvkOwIV9ztCyWFWgA8+pkjMhaDMarN7qKRcesfTnhFFFStMMvvypnqPZzJe7pWydv5QhIJkmiOHisQkRbUYcbxrZLu4bKNFFxys0CsLpGcJ8IESyY1S9d967i7SpR0o8Ib8Rb76zSYW5YSVPy5SzNkiT5qezugOo6vEy1TpCdG2F30XnU9D625TILvHtnGL3RyizLG9ynRhKy4cy42k1IJKw1pvqR0gL6BPFRfXtrX/dM9DBZ8AWAFop78M/KSQCDPApwto9qmLf51DqwVS4ZUhaLI7JqU7qNC1j65zMO+3SjBvN6Ozw==;20:+47j+Z46xrq74ykuNH55cLyv1l0LKGkbrlDd3nbQfLA7uCctClyJLCGR+cQmY3D0677hKqJXODlZosIaPVrQUoTqwNUNCuPzG4w6qvWCNg5QJ3N4BGyP8nMUKVaR0a1rcy3Y4bbNiUftfNYJOM0WXwrYBZEal3Px4RK/US33FkQ= x-ms-office365-filtering-correlation-id: b28bdfd2-0fa9-4d71-5a84-08d48e45b033 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:SG2PR06MB1166; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:; x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(3002001)(10201501046)(93006095)(93001095)(6055026)(6041248)(20161123555025)(20161123560025)(20161123562025)(20161123564025)(201703131423075)(201702281528075)(201703061421075)(6072148);SRVR:SG2PR06MB1166;BCL:0;PCL:0;RULEID:;SRVR:SG2PR06MB1166; x-forefront-prvs: 029174C036 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(6009001)(39450400003)(39860400002)(39400400002)(39850400002)(39840400002)(39410400002)(24454002)(4326008)(9686003)(7736002)(189998001)(3660700001)(25786009)(229853002)(66066001)(2900100001)(6916009)(122556002)(2950100002)(53936002)(50986999)(86362001)(76176999)(93886004)(110136004)(54356999)(38730400002)(7696004)(7416002)(6116002)(3280700002)(8936002)(102836003)(74316002)(6506006)(55016002)(3846002)(77096006)(99286003)(6436002)(33656002)(305945005)(5660300001)(6246003)(54906002)(2906002)(81166006)(8676002);DIR:OUT;SFP:1102;SCL:1;SRVR:SG2PR06MB1166;H:SG2PR06MB1165.apcprd06.prod.outlook.com;FPR:;SPF:None;MLV:sfv;LANG:en; spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 X-OriginatorOrg: renesas.com X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2017 14:48:52.4721 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 53d82571-da19-47e4-9cb4-625a166a4a2a X-MS-Exchange-Transport-CrossTenantHeadersStamped: SG2PR06MB1166 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3SEnj3E001726 Content-Length: 1222 Lines: 31 Hi Geert, On Friday, April 28, 2017, Geert Uytterhoeven wrote: > >> Shouldn't the interrupt (connected to P1_15) be described? > > > > That interrupt pin from the PHY is not used. It did not need to be > connected. > > But it is connected, according to the schematics. P1_15 can be configured as: * GPIO_IN * AN7 * AVB_CAPTURE So...I guess you would 'describe' it as an GPIO-input. > DT describes hardware, not software limitations. Describing things is fine, but the kernel code takes the DT and then start configuring things based on it. For example, on the RSK board, that line is connected to P4_14. P4_14 can be configured as IRQ6...but IRQ6 comes out in 8 different pin choices, and I might want to use one of those other choices, so I don't want to describe P4_14 as an interrupt. If it was just describing that "pin 15 of the PHY chip is tied to pin Y19 of the RZ/A1H", that's fine because it's hardware connection that's not going to change. But...the DT also defines the pin muxing...which is a software decision (do I want to get interrupt or just manually poll or simple ignore it). This is the part of the whole "DT is for hardware description only" that doesn't really make sense to me. Chris