DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 238EC75725
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From: David Howells <dhowells@redhat.com>
In-Reply-To: <73122870-E138-4DA5-90C9-91CB664E7DF1@linux.vnet.ibm.com>
References: <73122870-E138-4DA5-90C9-91CB664E7DF1@linux.vnet.ibm.com> <1492727320-26194-4-git-send-email-mkayaalp@linux.vnet.ibm.com> <1492727320-26194-1-git-send-email-mkayaalp@linux.vnet.ibm.com> <13470.1493301291@warthog.procyon.org.uk>
To: Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com>
Cc: dhowells@redhat.com, David Woodhouse <dwmw2@infradead.org>,
        keyrings <keyrings@vger.kernel.org>,
        LSM <linux-security-module@vger.kernel.org>,
        kernel <linux-kernel@vger.kernel.org>,
        Mimi Zohar <zohar@linux.vnet.ibm.com>,
        Stefan Berger <stefanb@linux.vnet.ibm.com>,
        George Wilson <gcwilson@us.ibm.com>
Subject: Re: [PATCH v4 3/4] KEYS: Support for inserting a certificate into x86 bzImage
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <485.1493394457.1@warthog.procyon.org.uk>
Date: Fri, 28 Apr 2017 16:47:37 +0100
Message-ID: <486.1493394457@warthog.procyon.org.uk>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 635
Lines: 19

Mehmet Kayaalp <mkayaalp@linux.vnet.ibm.com> wrote:

> >> +	/* TODO: update CRC */
> > 
> > Is this bit missing?
> 
> I didn't add it, since I wasn't sure it was still used with secure boot.

I'm not sure why secure boot would skip it if normal boot does it.  You'll
have to trawl the boot wrapper and kernel arch setup code to answer that one.

> The CRC code is implemented in multiple places, but not exposed to the
> tools/scripts.  Should I make the crc32() in tools/pcmcia/crc32hash.c
> non-static, maybe?

Making it non-static won't help since it's a standalone program.  You could
just shift it to scripts or something.

David