Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S638126AbdD1QX1 (ORCPT ); Fri, 28 Apr 2017 12:23:27 -0400 Received: from mail-qk0-f175.google.com ([209.85.220.175]:33417 "EHLO mail-qk0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S939073AbdD1QXS (ORCPT ); Fri, 28 Apr 2017 12:23:18 -0400 MIME-Version: 1.0 In-Reply-To: References: <1493281194-5200-1-git-send-email-jacopo+renesas@jmondi.org> <1493281194-5200-3-git-send-email-jacopo+renesas@jmondi.org> From: Andy Shevchenko Date: Fri, 28 Apr 2017 19:23:17 +0300 Message-ID: Subject: Re: [PATCH v5 02/10] pinctrl: generic: Add macros to unpack properties To: Linus Walleij Cc: Jacopo Mondi , Geert Uytterhoeven , Laurent Pinchart , Chris Brandt , Rob Herring , Mark Rutland , Russell King , Linux-Renesas , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 423 Lines: 19 On Fri, Apr 28, 2017 at 11:16 AM, Linus Walleij wrote: > On Thu, Apr 27, 2017 at 10:19 AM, Jacopo Mondi > wrote: > But why. > > I have these two static inlines just below your new macros: +1. > We generally prefer static inlines over macros because they are easier > to read. Not only. It adds type checking as well AFAIUC. -- With Best Regards, Andy Shevchenko