Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S969081AbdD1RKw (ORCPT ); Fri, 28 Apr 2017 13:10:52 -0400 Received: from mx1.redhat.com ([209.132.183.28]:34096 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S968382AbdD1RKn (ORCPT ); Fri, 28 Apr 2017 13:10:43 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 816138E3EE Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx01.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=dledford@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 816138E3EE Message-ID: <1493399442.3041.159.camel@redhat.com> Subject: Re: [PATCH 1/1] iw_cxgb4: check return value of alloc_skb From: Doug Ledford To: Pan Bian , Steve Wise , Sean Hefty , Hal Rosenstock Cc: linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Date: Fri, 28 Apr 2017 13:10:42 -0400 In-Reply-To: <1492938551-17824-1-git-send-email-bianpan2016@163.com> References: <1492938551-17824-1-git-send-email-bianpan2016@163.com> Organization: Red Hat, Inc. Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Fri, 28 Apr 2017 17:10:43 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 540 Lines: 16 On Sun, 2017-04-23 at 17:09 +0800, Pan Bian wrote: > Function alloc_skb() will return a NULL pointer when there is no > enough > memory. However, the return value of alloc_skb() is directly used > without validation in function send_fw_pass_open_req(). This patches > checks the return value of alloc_skb() against NULL. > > Signed-off-by: Pan Bian Thanks, applied. -- Doug Ledford     GPG KeyID: B826A3330E572FDD     Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD