Date: Thu, 5 Jun 2003 09:33:37 -0700
From: Greg KH <greg@kroah.com>
To: Dave Jones <davej@codemonkey.org.uk>,
       James Morris <jmorris@intercode.com.au>, pam.delaney@lsil.com,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH] compile fix for MPT Fusion driver for 2.5.70 bk
Message-ID: <20030605163337.GA5101@kroah.com>
References: <Mutt.LNX.4.44.0306060154230.2735-100000@excalibur.intercode.com.au> <20030605162901.GA7035@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20030605162901.GA7035@suse.de>
User-Agent: Mutt/1.4.1i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1673
Lines: 42

On Thu, Jun 05, 2003 at 05:29:01PM +0100, Dave Jones wrote:
> On Fri, Jun 06, 2003 at 02:01:22AM +1000, James Morris wrote:
>  > The patch below fixes compilation for the MPT Fusion driver, which broke 
>  > with recent changes to the PCI API.
>  > 
>  > It seems that the code is trying to detect which version of the API its 
>  > being compiled for, but the macro it was looking for has disappeared.
> 
> This looks bogus to me.
> 
>  > diff -urN -X dontdiff bk.pending/drivers/message/fusion/linux_compat.h bk.w1/drivers/message/fusion/linux_compat.h
>  > --- bk.pending/drivers/message/fusion/linux_compat.h	2003-06-06 00:36:11.000000000 +1000
>  > +++ bk.w1/drivers/message/fusion/linux_compat.h	2003-06-06 01:48:49.000000000 +1000
>  > @@ -147,7 +147,7 @@
>  >  
>  >  
>  >  /* PCI/driver subsystem { */
>  > -#ifndef pci_for_each_dev
>  > +#ifndef pci_for_each_dev_reverse
>  >  #define pci_for_each_dev(dev)		for((dev)=pci_devices; (dev)!=NULL; (dev)=(dev)->next)
> 
> What has _reverse got to do with this define ?

Nothing, he's just trying to detect the kernel version.  I'll just
change that to a:
	#if 0
for now, and let the fusion maintainer fix it up how they see fit based
on old kernel versions, if they want to.

> Whilst on the subject, how come we still have the _reverse method now
> that pci_for_each_dev is dead ?

Because I hadn't gotten to it yet, that was on the plate for today :)

thanks,

greg k-h
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/