Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S642229AbdD1RtD (ORCPT ); Fri, 28 Apr 2017 13:49:03 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:60234 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S642168AbdD1Rs7 (ORCPT ); Fri, 28 Apr 2017 13:48:59 -0400 DMARC-Filter: OpenDMARC Filter v1.3.2 smtp.codeaurora.org F183161322 Authentication-Results: pdx-caf-mail.web.codeaurora.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: pdx-caf-mail.web.codeaurora.org; spf=none smtp.mailfrom=sboyd@codeaurora.org Date: Fri, 28 Apr 2017 10:48:56 -0700 From: Stephen Boyd To: Maxime Ripard Cc: Arnd Bergmann , Chen-Yu Tsai , Michael Turquette , Icenowy Zheng , Tobias Regnery , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] clk: sunxi-ng: always select CCU_GATE Message-ID: <20170428174856.GA7065@codeaurora.org> References: <20170427110239.2389266-1-arnd@arndb.de> <20170428073542.jamyyjgafirqtth4@lukather> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170428073542.jamyyjgafirqtth4@lukather> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1134 Lines: 29 On 04/28, Maxime Ripard wrote: > 1;4601;0c > On Thu, Apr 27, 2017 at 01:02:31PM +0200, Arnd Bergmann wrote: > > When the base driver is enabled but all SoC specific drivers are turned > > off, we now get a build error after code was added to always refer to the > > clk gates: > > > > drivers/clk/built-in.o: In function `ccu_pll_notifier_cb': > > :(.text+0x154f8): undefined reference to `ccu_gate_helper_disable' > > :(.text+0x15504): undefined reference to `ccu_gate_helper_enable' > > > > This changes the Kconfig to always require the gate code to be built-in > > when CONFIG_SUNXI_CCU is set. > > > > Fixes: 02ae2bc6febd ("clk: sunxi-ng: Add clk notifier to gate then ungate PLL clocks") > > Signed-off-by: Arnd Bergmann > > Acked-by: Maxime Ripard > > Stephen, Mike, can you apply this patch directly? This affects the > current (4.11) release, so we probably don't want to have the overhead > of a PR here :/ > Yep. Applied to fixes to be sent off today. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project