Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S642313AbdD1S32 (ORCPT ); Fri, 28 Apr 2017 14:29:28 -0400 Received: from mail-io0-f195.google.com ([209.85.223.195]:36764 "EHLO mail-io0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S938059AbdD1S3R (ORCPT ); Fri, 28 Apr 2017 14:29:17 -0400 Date: Fri, 28 Apr 2017 13:29:13 -0500 From: Rob Herring To: Eric Anholt Cc: dri-devel@lists.freedesktop.org, Mark Rutland , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/3 v3] drm/vc4: Turn the V3D clock on at runtime. Message-ID: <20170428182913.pv73xj45onxlnd3c@rob-hp-laptop> References: <7906db2f-cfb8-e2e6-5869-b6e829dd8c6f@gmail.com> <20170424201209.31148-1-eric@anholt.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170424201209.31148-1-eric@anholt.net> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1529 Lines: 34 On Mon, Apr 24, 2017 at 01:12:09PM -0700, Eric Anholt wrote: > For the Raspberry Pi's bindings, the power domain also implicitly > turns on the clock and deasserts reset, but for the new Cygnus port we > start representing the clock in the devicetree. > > v2: Document the clock-names property, check for -ENOENT for no clock > in DT. > v3: Drop NULL checks around clk calls which embed NULL checks. > > Signed-off-by: Eric Anholt > --- > .../devicetree/bindings/display/brcm,bcm-vc4.txt | 4 +++ > drivers/gpu/drm/vc4/vc4_drv.h | 1 + > drivers/gpu/drm/vc4/vc4_v3d.c | 31 +++++++++++++++++++++- > 3 files changed, 35 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt > index ca02d3e4db91..2318266f6481 100644 > --- a/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt > +++ b/Documentation/devicetree/bindings/display/brcm,bcm-vc4.txt > @@ -59,6 +59,10 @@ Required properties for V3D: > - interrupts: The interrupt number > See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt > > +Optional properties for V3D: > +- clocks: The clock the unit runs on > +- clock-names: Must be "v3d_clk" clock-names is pointless for a single clock. > + > Required properties for DSI: > - compatible: Should be "brcm,bcm2835-dsi0" or "brcm,bcm2835-dsi1" > - reg: Physical base address and length of the DSI block's registers