From: "Kani, Toshimitsu" <toshi.kani@hpe.com>
To: "dan.j.williams@intel.com" <dan.j.williams@intel.com>
CC: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "dave.jiang@intel.com" <dave.jiang@intel.com>,
        "linux-nvdimm@lists.01.org" <linux-nvdimm@ml01.01.org>,
        "vishal.l.verma@intel.com" <vishal.l.verma@intel.com>
Subject: Re: [PATCH 1/2] libnvdimm: fix clear length of nvdimm_forget_poison()
Thread-Topic: [PATCH 1/2] libnvdimm: fix clear length of
 nvdimm_forget_poison()
Thread-Index: AQHSv6m7gGeP0lAs30ynvJerDiEMOqHbUueAgAALW4CAAALjgIAAAKEA
Date: Fri, 28 Apr 2017 22:41:53 +0000
Message-ID: <1493419278.30303.8.camel@hpe.com>
References: <20170427225706.26791-1-toshi.kani@hpe.com>
         <CAPcyv4i+U62GMyK=xNXB9ZjzS-028q4Qch=kxa9_pkwXrFJdsA@mail.gmail.com>
         <1493418523.30303.6.camel@hpe.com>
         <CAPcyv4jyH=kyBy7-NW77NdssqUKpE2=uf3VfOjk7A5zeUgMAMA@mail.gmail.com>
In-Reply-To: <CAPcyv4jyH=kyBy7-NW77NdssqUKpE2=uf3VfOjk7A5zeUgMAMA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="utf-8"
Content-ID: <C4CC909238E0974994BB4F1A147780ED@NAMPRD84.PROD.OUTLOOK.COM>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Apr 2017 22:41:53.2609
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AT5PR84MB0259
X-OriginatorOrg: hpe.com
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v3SMg87P031580
Content-Length: 1158
Lines: 32

On Fri, 2017-04-28 at 15:39 -0700, Dan Williams wrote:
> On Fri, Apr 28, 2017 at 3:29 PM, Kani, Toshimitsu <toshi.kani@hpe.com
> > wrote:
> > On Fri, 2017-04-28 at 14:48 -0700, Dan Williams wrote:
> > > On Thu, Apr 27, 2017 at 3:57 PM, Toshi Kani <toshi.kani@hpe.com>
 :
> > > > 
> > > > -       nvdimm_forget_poison(nvdimm_bus, phys, len);
> > > > +       if (clear_err.cleared > 0)
> > > > +               nvdimm_forget_poison(nvdimm_bus, phys,
> > > > clear_err.cleared);
> > > > +
> > > >         return clear_err.cleared;
> > > 
> > > Looks, good we need to mark this for -stable since the bug is
> > > also present in current mainline.
> > > 
> > > Fixes: e046114af5fc ("libnvdimm: clear the internal poison_list
> > > when clearing badblocks")
> > 
> > Shall I send a patch based on the current mainline with cc to
> > -stable?  The func name is nvdimm_clear_from_poison_list() in the
> > mainline.
> 
> I thinks it's too late to get a fix into 4.11, especially when this
> went in broken and not a regression. I'll just tag this for -stable
> and handle the backport manually.

Sounds great. Thanks Dan!
-Toshi