Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1426000AbdD2AMl (ORCPT ); Fri, 28 Apr 2017 20:12:41 -0400 Received: from mail-oi0-f46.google.com ([209.85.218.46]:34789 "EHLO mail-oi0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1164576AbdD2AMe (ORCPT ); Fri, 28 Apr 2017 20:12:34 -0400 MIME-Version: 1.0 In-Reply-To: References: <20170427225706.26791-1-toshi.kani@hpe.com> <20170427225706.26791-2-toshi.kani@hpe.com> From: Dan Williams Date: Fri, 28 Apr 2017 17:12:33 -0700 Message-ID: Subject: Re: [PATCH 2/2] libnvdimm: clear region badblock in nvdimm_clear_poison() To: Toshi Kani Cc: Dave Jiang , Vishal L Verma , "linux-nvdimm@lists.01.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1077 Lines: 24 On Fri, Apr 28, 2017 at 5:10 PM, Dan Williams wrote: > On Thu, Apr 27, 2017 at 3:57 PM, Toshi Kani wrote: >> Badblocks are tracked at both region and device levels. >> pmem_clear_poison() and nsio_rw_bytes() call nvdimm_clear_poison() >> and then badblocks_clear() to clear badblocks at the device level. >> However, it does not update badblocks at the region level, which >> makes them inconsistent. >> >> Change nvdimm_clear_poison() to update backblocks at the region >> level to keep them consistent. >> >> Signed-off-by: Toshi Kani >> Cc: Dan Williams >> Cc: Dave Jiang >> Cc: Vishal Verma > > This looks good, and it seems we have a bug in the other location that > does this in __nd_ioctl(). That other one is missing the > "clear_err.cleared / 512" check. Can you respin this and define a > common helper that both locations can call? On second thought, I'll take this and spin my own cleanup / fix on top. Thanks Toshi!