Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1165461AbdD2ART (ORCPT ); Fri, 28 Apr 2017 20:17:19 -0400 Received: from web01.01d.eu ([5.200.27.195]:34048 "EHLO web01.01d.eu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1163675AbdD2ARM (ORCPT ); Fri, 28 Apr 2017 20:17:12 -0400 X-Greylist: delayed 4160 seconds by postgrey-1.27 at vger.kernel.org; Fri, 28 Apr 2017 20:17:11 EDT From: Shiva Kerdel To: thomas.petazzoni@free-electrons.com Cc: gregkh@linuxfoundation.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Shiva Kerdel Subject: [PATCH] staging: fbtft: fbtft-core.c: EXPORT_SYMBOL should immediately follow its function Date: Sat, 29 Apr 2017 01:07:34 +0200 Message-Id: <20170428230734.14533-1-shiva@exdev.nl> X-Mailer: git-send-email 2.10.2 X-Authenticated-Id: shiva@exdev.nl Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2015 Lines: 67 This patch fixes the following checkpatch.pl warning - EXPORT_SYMBOL(foo); should immediately follow its function/variable Signed-off-by: Shiva Kerdel --- drivers/staging/fbtft/fbtft-core.c | 25 +++++++++++++++---------- 1 file changed, 15 insertions(+), 10 deletions(-) diff --git a/drivers/staging/fbtft/fbtft-core.c b/drivers/staging/fbtft/fbtft-core.c index b742ee7..b004a4d 100644 --- a/drivers/staging/fbtft/fbtft-core.c +++ b/drivers/staging/fbtft/fbtft-core.c @@ -275,23 +275,31 @@ static int fbtft_backlight_get_brightness(struct backlight_device *bd) return bd->props.brightness; } +static const struct backlight_ops fbtft_bl_ops = { + .get_brightness = fbtft_backlight_get_brightness, + .update_status = fbtft_backlight_update_status, +}; +#endif + void fbtft_unregister_backlight(struct fbtft_par *par) { + #ifdef CONFIG_FB_BACKLIGHT + if (par->info->bl_dev) { par->info->bl_dev->props.power = FB_BLANK_POWERDOWN; backlight_update_status(par->info->bl_dev); backlight_device_unregister(par->info->bl_dev); par->info->bl_dev = NULL; } -} -static const struct backlight_ops fbtft_bl_ops = { - .get_brightness = fbtft_backlight_get_brightness, - .update_status = fbtft_backlight_update_status, -}; + #endif +} +EXPORT_SYMBOL(fbtft_unregister_backlight); void fbtft_register_backlight(struct fbtft_par *par) { + #ifdef CONFIG_FB_BACKLIGHT + struct backlight_device *bd; struct backlight_properties bl_props = { 0, }; @@ -320,13 +328,10 @@ void fbtft_register_backlight(struct fbtft_par *par) if (!par->fbtftops.unregister_backlight) par->fbtftops.unregister_backlight = fbtft_unregister_backlight; + + #endif } -#else -void fbtft_register_backlight(struct fbtft_par *par) { }; -void fbtft_unregister_backlight(struct fbtft_par *par) { }; -#endif EXPORT_SYMBOL(fbtft_register_backlight); -EXPORT_SYMBOL(fbtft_unregister_backlight); static void fbtft_set_addr_win(struct fbtft_par *par, int xs, int ys, int xe, int ye) -- 2.10.2