Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S939957AbdD2Crr (ORCPT ); Fri, 28 Apr 2017 22:47:47 -0400 Received: from zeniv.linux.org.uk ([195.92.253.2]:56300 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936258AbdD2Crh (ORCPT ); Fri, 28 Apr 2017 22:47:37 -0400 Date: Sat, 29 Apr 2017 03:47:36 +0100 From: Al Viro To: Dave Jones , Linux Kernel Subject: Re: iov_iter_pipe warning. Message-ID: <20170429024736.GP29622@ZenIV.linux.org.uk> References: <20170412162709.bn5qfk4seues3yos@codemonkey.org.uk> <20170412170723.GQ29622@ZenIV.linux.org.uk> <20170412190318.srkkdytf2ebrjzrg@codemonkey.org.uk> <20170421175430.GT29622@ZenIV.linux.org.uk> <20170428152955.mafs3f22srmm34aw@codemonkey.org.uk> <20170428164313.GK29622@ZenIV.linux.org.uk> <20170428165024.ofyl2atpjwohekqa@codemonkey.org.uk> <20170428172024.GL29622@ZenIV.linux.org.uk> <20170428182511.GM29622@ZenIV.linux.org.uk> <20170429015847.p5gpz5px6vybewvs@codemonkey.org.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170429015847.p5gpz5px6vybewvs@codemonkey.org.uk> User-Agent: Mutt/1.7.1 (2016-10-04) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 745 Lines: 18 On Fri, Apr 28, 2017 at 09:58:47PM -0400, Dave Jones wrote: > On Fri, Apr 28, 2017 at 07:25:12PM +0100, Al Viro wrote: > > On Fri, Apr 28, 2017 at 06:20:25PM +0100, Al Viro wrote: > > > On Fri, Apr 28, 2017 at 12:50:24PM -0400, Dave Jones wrote: > > > > currently running v4.11-rc8-75-gf83246089ca0 > > > > > > > > sunrpc bit is for the other unrelated problem I'm chasing. > > > > > > > > note also, I saw the backtrace without the fs/splice.c changes. > > > > > > Interesting... Could you add this and see if that triggers? > > > > Gyah... It's a bloody dumb braino in iov_iter_revert() for pipe-backed > > ones. Sorry, the oneliner below should fix it. > > 5 hrs in, looking good so far. Mind your Tested-by on the fix?