Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S940029AbdD2RSQ (ORCPT ); Sat, 29 Apr 2017 13:18:16 -0400 Received: from mail-he1eur01on0040.outbound.protection.outlook.com ([104.47.0.40]:21408 "EHLO EUR01-HE1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S940000AbdD2RSI (ORCPT ); Sat, 29 Apr 2017 13:18:08 -0400 From: =?iso-8859-2?Q?Horia_Geant=E3?= To: Stuart Yoder CC: "gregkh@linuxfoundation.org" , Roy Pledge , "devel@driverdev.osuosl.org" , "linux-kernel@vger.kernel.org" , Ruxandra Ioana Radulescu , Haiying Wang Subject: Re: [PATCH] staging: fsl-mc/dpio: add cpu <--> LE conversion for dpaa2_fd Thread-Topic: [PATCH] staging: fsl-mc/dpio: add cpu <--> LE conversion for dpaa2_fd Thread-Index: AQHSwQZCkSvY/KcKpk+aS8uH0i5A2A== Date: Sat, 29 Apr 2017 17:18:04 +0000 Message-ID: References: <20170428143858.15992-1-horia.geanta@nxp.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: authentication-results: gmail.com; dkim=none (message not signed) header.d=none;gmail.com; dmarc=none action=none header.from=nxp.com; x-originating-ip: [79.118.211.60] x-microsoft-exchange-diagnostics: 1;VI1PR0401MB2558;7:weZqjzow+hkAtRr4smX7QDMtczDNvGjEyageswR04u62GvTyID+y/NQJ8iQqdnmdMvwiWzMqh10fT6cJh/7r1MAhzz7pbkZCp5ixxwq/EypnPeA2SpkezT4arvCVLI7yUqyiwC/Q/FceyCpv548URpLAcL513AD7b/Ow7keJ6T2MgdXeQQHBC0WzlhlaMdY5sCemFF+zAbF1t9CjZ2mCG3N4fXS8P0+sCB7h0ZLFGUV1aDT2RtI7lxJm2Ye+ndAJEfONDPqIIp7JNj7bLvI8aq3+nLIqAiyk1GVUa8W/2gTp7MS4V3KJfsnGX2t6g5NciC3wNMFtK2qkN1cKDikgIg== x-forefront-antispam-report: SFV:SKI;SCL:-1SFV:NSPM;SFS:(10009020)(6009001)(39410400002)(39400400002)(39850400002)(39450400003)(39840400002)(39860400002)(24454002)(377454003)(7696004)(2906002)(305945005)(74316002)(66066001)(7736002)(189998001)(229853002)(508600001)(33656002)(25786009)(1411001)(4326008)(2900100001)(39060400002)(53546009)(54356999)(50986999)(76176999)(81166006)(6436002)(8676002)(6506006)(110136004)(9686003)(3280700002)(55016002)(99286003)(54906002)(53936002)(3660700001)(5660300001)(8936002)(77096006)(6916009)(86362001)(122556002)(102836003)(6116002)(6246003)(3846002)(38730400002);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR0401MB2558;H:VI1PR0401MB2591.eurprd04.prod.outlook.com;FPR:;SPF:None;MLV:ovrnspm;PTR:InfoNoRecords;LANG:en; x-ms-office365-filtering-correlation-id: 8651b544-a81b-430f-ec40-08d48f23b280 x-ms-office365-filtering-ht: Tenant x-microsoft-antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254075)(48565401081)(201703131423075)(201703031133081)(201702281549075);SRVR:VI1PR0401MB2558; x-microsoft-antispam-prvs: x-exchange-antispam-report-test: UriScan:(185117386973197); x-exchange-antispam-report-cfa-test: BCL:0;PCL:0;RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006095)(93001095)(6055026)(6041248)(201703131423075)(201702281528075)(201703061421075)(20161123555025)(20161123562025)(20161123564025)(20161123560025)(6072148);SRVR:VI1PR0401MB2558;BCL:0;PCL:0;RULEID:;SRVR:VI1PR0401MB2558; x-forefront-prvs: 02929ECF07 spamdiagnosticoutput: 1:99 spamdiagnosticmetadata: NSPM Content-Type: text/plain; charset="iso-8859-2" MIME-Version: 1.0 X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Apr 2017 17:18:04.4861 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR0401MB2558 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id v3THLSb7001547 Content-Length: 676 Lines: 21 On 4/29/2017 7:32 PM, Stuart Yoder wrote: > On Fri, Apr 28, 2017 at 9:38 AM, Horia Geant? wrote: >> >> While dpaa2_fd.simple structure fields are marked __leXX, >> corresponding cpu_to_leXX / leXX_to_cpu conversions are missing. >> >> While here, fix dpaa2_fd_{get,set}_bpid such that BMT, IVP bits >> sharing the 16-bit field with BPID are not affected. > > Please split this into 2 separate patches. Don't fix other misc things "while > you are at it" in the same patch. > I thought that having 2 issues on the same line would allow for this approach. Now that the patch is in staging-next, I am not sure what I am supposed to do. Thanks, Horia