Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S969921AbdD3OxS (ORCPT <rfc822;w@1wt.eu>);
        Sun, 30 Apr 2017 10:53:18 -0400
Received: from conssluserg-01.nifty.com ([210.131.2.80]:48178 "EHLO
        conssluserg-01.nifty.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S967435AbdD3OxL (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Sun, 30 Apr 2017 10:53:11 -0400
DKIM-Filter: OpenDKIM Filter v2.10.3 conssluserg-01.nifty.com v3UEr5pc002791
X-Nifty-SrcIP: [209.85.213.179]
MIME-Version: 1.0
In-Reply-To: <87shkwi73g.fsf@belgarion.home>
References: <1481819733-3002-1-git-send-email-robert.jarzmik@free.fr>
 <CAK7LNAQN2ZRFETM818ySYSOx1Tykhq7RCYeyFv=x1ARH7w7cww@mail.gmail.com> <87shkwi73g.fsf@belgarion.home>
From: Masahiro Yamada <yamada.masahiro@socionext.com>
Date: Sun, 30 Apr 2017 23:53:05 +0900
X-Gmail-Original-Message-ID: <CAK7LNARpU2Stv2=jWiK2z1WxY-EnKACkJbnFWOaD1POigGvSug@mail.gmail.com>
Message-ID: <CAK7LNARpU2Stv2=jWiK2z1WxY-EnKACkJbnFWOaD1POigGvSug@mail.gmail.com>
Subject: Re: [PATCH v2] tags: honor COMPILED_SOURCE with apart output directory
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Michal Marek <mmarek@suse.com>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 1308
Lines: 41

Hi Robert,

2017-04-26 5:07 GMT+09:00 Robert Jarzmik <robert.jarzmik@free.fr>:
> Masahiro Yamada <yamada.masahiro@socionext.com> writes:
>
>> Hi Robert,
>>> diff --git a/scripts/tags.sh b/scripts/tags.sh
>>> index a2ff3388e5ea..35cb64d5211c 100755
>>> --- a/scripts/tags.sh
>>> +++ b/scripts/tags.sh
>>> @@ -106,7 +106,8 @@ all_compiled_sources()
>>>                 case "$i" in
>>>                         *.[cS])
>>>                                 j=${i/\.[cS]/\.o}
>>> -                               if [ -e $j ]; then
>>> +                               k="${j#$tree}"
>>> +                               if [ -e $j -o -e "$k" ]; then
>>
>>
>> Do we need to check both srctree and objtree?
>> I think checking objtree (after $tree is ripped off) is enough.
>
> If I remember correctly, as this goes back a couple of monthes when I made the
> tests of this patch, the srctree is checked for the case when the kernel is
> compiled without O=, and objtree for the case with O=.


I thought of this too, but if O= is given, objects in srctree
should not be checked.

For example, the kernel may be compiled for ARCH=arm with O= first,
then for ARCH=x86 without O= second.

If we include objects from both trees, the generated tag file
will be a mixture of arm and x86.



-- 
Best Regards
Masahiro Yamada