Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1949409AbdD3Upy (ORCPT ); Sun, 30 Apr 2017 16:45:54 -0400 Received: from mail-it0-f65.google.com ([209.85.214.65]:35942 "EHLO mail-it0-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1949339AbdD3Upn (ORCPT ); Sun, 30 Apr 2017 16:45:43 -0400 From: frowand.list@gmail.com To: Rob Herring , stephen.boyd@linaro.org Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC Date: Sun, 30 Apr 2017 13:45:28 -0700 Message-Id: <1493585128-12716-1-git-send-email-frowand.list@gmail.com> X-Mailer: git-send-email 1.9.1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1133 Lines: 35 From: Frank Rowand An undeclared variable was used in a macro that evaluates to nothing when CONFIG_DEBUG_LOCK_ALLOC is not defined. Change to use the correct variable that does exist. --- reported by kbuild test robot on on robh/for-next https://lkml.org/lkml/2017/4/29/134 drivers/of/base.c: In function '__of_add_phandle_sysfs': >> drivers/of/base.c:198:23: error: 'pp' undeclared (first use in this function) sysfs_bin_attr_init(&pp->attr); Signed-off-by: Frank Rowand --- drivers/of/base.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/base.c b/drivers/of/base.c index 9fe42346925b..8a7ca2a49ba8 100644 --- a/drivers/of/base.c +++ b/drivers/of/base.c @@ -195,7 +195,7 @@ int __of_add_phandle_sysfs(struct device_node *np) if (!np->phandle || np->phandle == 0xffffffff) return 0; - sysfs_bin_attr_init(&pp->attr); + sysfs_bin_attr_init(&np->attr_phandle); np->attr_phandle.attr.name = "phandle"; np->attr_phandle.attr.mode = 0444; np->attr_phandle.size = sizeof(np->phandle); -- Frank Rowand