Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1165267AbdEACef (ORCPT ); Sun, 30 Apr 2017 22:34:35 -0400 Received: from shards.monkeyblade.net ([184.105.139.130]:54282 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1162752AbdEACe1 (ORCPT ); Sun, 30 Apr 2017 22:34:27 -0400 Date: Sun, 30 Apr 2017 22:34:25 -0400 (EDT) Message-Id: <20170430.223425.472451891993812438.davem@davemloft.net> To: karim.eshapa@gmail.com Cc: sathya.perla@broadcom.com, ajit.khaparde@broadcom.com, sriharsha.basavapatna@broadcom.com, somnath.kotur@broadcom.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, kaim.eshapa@gmail.com Subject: Re: [PATCH] drivers:net:ethernet:emulex:benet: Use time_before_eq for time comparison From: David Miller In-Reply-To: <1493344139-6678-1-git-send-email-karim.eshapa@gmail.com> References: <1493344139-6678-1-git-send-email-karim.eshapa@gmail.com> X-Mailer: Mew version 6.7 on Emacs 25.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Sun, 30 Apr 2017 18:53:01 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 469 Lines: 16 From: Karim Eshapa Date: Fri, 28 Apr 2017 03:48:59 +0200 > Use time_before_eq for time comparison more safe and dealing > with timer wrapping to be future-proof. > > Signed-off-by: Karim Eshapa Subject line has way too many subsystem prefixes, simply "benet: " is sufficient. And in situations where multiple subsystem prefixes are appropriate, one must put a space after each one like "one: two: three: ". Thanks.