Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1954763AbdDYVKJ (ORCPT + 2 others); Tue, 25 Apr 2017 17:10:09 -0400 Received: from mail-it0-f50.google.com ([209.85.214.50]:33891 "EHLO mail-it0-f50.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1031744AbdDYVJ7 (ORCPT ); Tue, 25 Apr 2017 17:09:59 -0400 Date: Tue, 25 Apr 2017 14:09:56 -0700 From: Tejun Heo Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Vincent Guittot , Mike Galbraith , Paul Turner , Chris Mason , kernel-team@fb.com Subject: Re: [PATCH 3/2] sched/fair: Skip __update_load_avg() on cfs_rq sched_entities Message-ID: <20170425210956.GC20255@wtj.duckdns.org> References: <20170424201344.GA14169@wtj.duckdns.org> <20170424213528.GB23619@wtj.duckdns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170424213528.GB23619@wtj.duckdns.org> 1;4601;0cTo: Ingo Molnar , Peter Zijlstra User-Agent: Mutt/1.8.0 (2017-02-23) To: unlisted-recipients:; (no To-header on input) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Return-Path: On Mon, Apr 24, 2017 at 02:35:28PM -0700, Tejun Heo wrote: > Now that a cfs_rq sched_entity's load_avg always gets propagated from > the associated cfs_rq, there's no point in calling __update_load_avg() > on it. The two mechanisms compete with each other and we'd be always > using a value close to the propagated one anyway. > > Skip __update_load_avg() for cfs_rq sched_entities. Also, relocate > propagate_entity_load_avg() to signify that propagation is the > counterpart to __update_load_avg() for cfs_rq sched_entities. This > puts the propagation before update_cfs_rq_load_avg() which shouldn't > disturb anything. Please ignore this patch. As we don't propagate on decays, we still need __update_load_avg() on runanble_load_avg so that it can decay on its own. Thanks. -- tejun