Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751460AbdFAGv1 (ORCPT ); Thu, 1 Jun 2017 02:51:27 -0400 Received: from mout.gmx.net ([212.227.17.20]:49285 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751053AbdFAGvZ (ORCPT ); Thu, 1 Jun 2017 02:51:25 -0400 Subject: Re: [PATCH v2 1/6] ARM: imx6q: provide documentation for new fsl,pmic_stby_poweroff property To: Mark Rutland , Oleksij Rempel References: <20170531061457.23744-1-o.rempel@pengutronix.de> <20170531061457.23744-2-o.rempel@pengutronix.de> <20170531145255.GC10351@leverpostej> Cc: kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, Michael Turquette , Stephen Boyd , Rob Herring , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton From: Oleksij Rempel Message-ID: Date: Thu, 1 Jun 2017 08:50:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170531145255.GC10351@leverpostej> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="mqhHG7A28Bi5ojtFwwc5pNTD1cqSe61KF" X-Provags-ID: V03:K0:eP4DvO7IqXa1wiIVHzCzfDhZmPwVntslW1J2y3KH1vTgHv6gNgv HGYm7Y3IeaRJp8jDl5KW88G3eyUhbBMWKFycyOBARQfvJIhRXgAzIXwJ9Whwn0AucZabqz4 m5xcs9Y8ZmPMAPslO3woHpou8hc8KVfRVKd7QvVXWEl81ba2+i492z4bBcRlbpBkLCQfX9O uPVODwmub1Vqi1ceW3v9Q== X-UI-Out-Filterresults: notjunk:1;V01:K0:3N0d5x/diO0=:v6bvcccwV5X5EsL9k2QfUt VNYGvbuaSlvVWEJ7tNjv3Jey9jZdPc9KTlUZDDCXlg8463oYzwhRfmRmPvt/C0PxiBRBkClmi j1EPfPkiqlGi19scmISz6b0SJpWmQuR1ZIW6H6co+LQtsrn9fNpdEtN42Mf71tErANFOmQyy8 dfRc7owY4bpLSQY0x3rBfpbFntS0o+rUNZn+sEvdTbdjp7vG71ygek4XvQjKJU4KedE2DzPSg Loh8F8XsSegMNy/UHF7wNOMd4pGazcW97HWQHXHnDo7QafPhKwHN5p1YdPHWZGble8uyZ7tfA jc1jRUxQwWuZPbSHZ1F4+kBMv/u+6c6lQPrCuXClsg+tdWlye7TS/Dxks4LNvAdWGcPAnJmAv Ne8TOx1CxAivRsvHnWJ6mcZpbxxSh/vD/D7PnFFI+PiIR5Iq1Ghhw35dq8GC0MfPw6JPJoWFT Iol0SvmXyp1Vu/npqAfDxsjIf5id1JWS9OuN7LZv81nIJZOZ8Mf7B457m0GXxabvSX08G4J4t 5PDXQIIlLP/ySYAGAvAOz8ihnxMmwxwmKbmVuej4P/jOOkY+7PMWxDQ4f29GwpAPWnBPD2t1I q/f1NPTxH8sTcxUbSm7GleVhV9F2DqAS5XIHf4BWdhNZiwdFA3zlncBN9WM6ii0vOf64jaUjj 8LP1+UtCI5Lx/21t10pgjZbBBFl1W2x2b1U7wzzfE06kDXr2oi0EpukWRZlKAkopjpYfawzyi qHpuhCGBrQYmVUVQsvm3rkypHkhGyGWjVXm47qTaKJrDqGYRBneqcmY7Lp8= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3741 Lines: 119 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --mqhHG7A28Bi5ojtFwwc5pNTD1cqSe61KF Content-Type: multipart/mixed; boundary="C7RPagmBr0a7D5kUOEPQDw7kQbnk7rr2h"; protected-headers="v1" From: Oleksij Rempel To: Mark Rutland , Oleksij Rempel Cc: kernel@pengutronix.de, linux-arm-kernel@lists.infradead.org, Michael Turquette , Stephen Boyd , Rob Herring , linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Morton Message-ID: Subject: Re: [PATCH v2 1/6] ARM: imx6q: provide documentation for new fsl,pmic_stby_poweroff property References: <20170531061457.23744-1-o.rempel@pengutronix.de> <20170531061457.23744-2-o.rempel@pengutronix.de> <20170531145255.GC10351@leverpostej> In-Reply-To: <20170531145255.GC10351@leverpostej> --C7RPagmBr0a7D5kUOEPQDw7kQbnk7rr2h Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: quoted-printable Am 31.05.2017 um 16:52 schrieb Mark Rutland: > On Wed, May 31, 2017 at 08:14:52AM +0200, Oleksij Rempel wrote: >> Signed-off-by: Oleksij Rempel >> Cc: kernel@pengutronix.de >> Cc: linux-arm-kernel@lists.infradead.org >> Cc: Michael Turquette >> Cc: Stephen Boyd >> Cc: Rob Herring >> Cc: Mark Rutland >> Cc: linux-clk@vger.kernel.org >> Cc: devicetree@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> --- >> Documentation/devicetree/bindings/clock/imx6q-clock.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.txt b= /Documentation/devicetree/bindings/clock/imx6q-clock.txt >> index 9252912a5b0e..214cb5f461c7 100644 >> --- a/Documentation/devicetree/bindings/clock/imx6q-clock.txt >> +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.txt >> @@ -6,6 +6,10 @@ Required properties: >> - interrupts: Should contain CCM interrupt >> - #clock-cells: Should be <1> >> =20 >> +Optional properties: >> +- fsl,pmic_stby_poweroff: Configure CCM to assert PMIC_STBY_REQ signa= l >> + on power off. >=20 > s/_/-/ in property names, please. ok. I have now some more questions: what naming schema should be actually used? fsl,pmic-stby-poweroff or fsl,pmic-stby-power-off i found some existing case: sound/rt5660.txt:- realtek,poweroff-in-suspend so in my case it will be: fsl,standby-in-poweroff or fsl,standby-in-power-off can we have generic name for this use case? should I use same binding for PMIC and the SoC or they should be more lik= e: for SoC "standby-in-power-off" and for PMIC "power-off-in-standby" > When/why is this needed? >=20 > Why should a DT author (not) set this? >=20 > Thanks, > Mark. >=20 >> + >> The clock consumer should specify the desired clock by having the clo= ck >> ID in its "clocks" phandle cell. See include/dt-bindings/clock/imx6q= dl-clock.h >> for the full list of i.MX6 Quad and DualLite clock IDs. >> --=20 >> 2.11.0 >> --=20 Regards, Oleksij --C7RPagmBr0a7D5kUOEPQDw7kQbnk7rr2h-- --mqhHG7A28Bi5ojtFwwc5pNTD1cqSe61KF Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iF4EAREIAAYFAlkvuTsACgkQHwImuRkmbWnjTgD+OMPXuh3DWAZ3dFKYKRlyWpRj 6G3lHy7rYcwSxcSEun8A/il84kXam14WDsmzKbTyuS9wcg2x2PfrvK3QsbiC0n25 =VV6G -----END PGP SIGNATURE----- --mqhHG7A28Bi5ojtFwwc5pNTD1cqSe61KF--