Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751509AbdFAJxz (ORCPT ); Thu, 1 Jun 2017 05:53:55 -0400 Received: from mx07-00178001.pphosted.com ([62.209.51.94]:26885 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751106AbdFAJxy (ORCPT ); Thu, 1 Jun 2017 05:53:54 -0400 From: Philippe CORNU To: Archit Taneja , Boris Brezillon CC: Eric Anholt , "dri-devel@lists.freedesktop.org" , Andrzej Hajda , Laurent Pinchart , CK Hu , Philipp Zabel , Yannick FERTRE , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. Thread-Topic: [PATCH v2 5/7] drm/ltdc: Use the panel-bridge helper. Thread-Index: AQHSyoTWeR4ludtxvk+5vJ+xXIRps6INFJOAgADihoCAABp+AIAAAdyAgAAHyACAAagJgA== Date: Thu, 1 Jun 2017 09:53:27 +0000 Message-ID: <536995e1-f805-bbec-c17c-ba318e5783c1@st.com> References: <20170511183128.25085-1-eric@anholt.net> <20170511183128.25085-5-eric@anholt.net> <20170531082627.5953f75b@bbrezillon> <20170531100755.1764b998@bbrezillon> <780d9b38-4645-64fc-43ab-d956d78e8933@codeaurora.org> In-Reply-To: <780d9b38-4645-64fc-43ab-d956d78e8933@codeaurora.org> Accept-Language: fr-FR, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: user-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 x-ms-exchange-messagesentrepresentingtype: 1 x-ms-exchange-transport-fromentityheader: Hosted x-originating-ip: [10.75.127.45] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-06-01_02:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id v519rxR2019408 Content-Length: 2479 Lines: 79 On 05/31/2017 10:35 AM, Archit Taneja wrote: > > > On 05/31/2017 01:37 PM, Boris Brezillon wrote: >> Hi Archit, >> >> Le Wed, 31 May 2017 13:31:16 +0530, >> Archit Taneja a écrit : >> >>> Hi Boris, >>> >>> On 05/31/2017 11:56 AM, Boris Brezillon wrote: >>>> Hi Philippe, >>>> >>>> Le Tue, 30 May 2017 16:55:42 +0000, >>>> Philippe CORNU a écrit : >>>> >>>>> Hi Eric, >>>>> >>>>> I took your patch for the panel-bridge and it works perfectly in both >>>>> DPI mode (panel RGB //) and DSI mode (bridge dw mipi dsi), bravo :-) >>>> >>>> I still don't understand how it can work without a call to >>>> drm_bridge_attach() (which is used to link the RGB encoder to the DPI >>>> connector). I'm probably missing something obvious. Maybe someone can >>>> point it out :-). >>> >>> I think the expectation is that there will be a follow-up patch that >>> would add bridge support. Philippe had posted a patch for adding bridges >>> to ltdc before: >>> >>> https://patchwork.kernel.org/patch/9724835/ >>> >>> He can now redo his patch over Eric's panel-bridge patch-set. >> >> But by doing that you're breaking bisectability, or is it working when >> applying only Eric's patchset? >> >> If applying this patch breaks the driver, why not applying it after >> bridge support has been added to this driver? > > Yeah, it would break the driver. Philippe can create a patch that adds > bridge support using the panel-bridge glue layer using Eric's patch as a > reference. In the end, there should only be a single patch. > > Thanks, > Archit > >> >> Regards, >> >> Boris >> > Hi Boris & Archit, Sorry, I should have been clearer about what I did. Let me explain more below: 1 - I applied Eric's patch named "drm/bridge: Refactor out the panel wrapper from the lvds-encoder bridge" (https://lkml.org/lkml/2017/5/11/784) 2 - I did a patch on ltdc.c combining Eric's patch named "drm/ltdc: Use the panel-bridge helper" (https://lkml.org/lkml/2017/5/11/783) and my own preamble patch for STM32 DSI named "drm/stm: ltdc: Add bridge support" (https://patchwork.kernel.org/patch/9738427/) And tests are successful in both DPI mode (panel RGB //) and DSI mode (bridge dw mipi dsi). As suggested in the last Archit's email, there will be a single patch that will add bridge support to ltdc.c and I will send it in the "STM32 DSI HOST" v3 version, if you all agree of course :) Many thanks for all your great comments, Philippe