Date: Thu, 1 Jun 2017 14:25:51 +0200
From: Peter Zijlstra <peterz@infradead.org>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Lu Baolu <baolu.lu@linux.intel.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        Ingo Molnar <mingo@redhat.com>,
        Mathias Nyman <mathias.nyman@linux.intel.com>, tglx@linutronix.de,
        linux-usb@vger.kernel.org, x86@kernel.org,
        linux-kernel@vger.kernel.org, Steven Rostedt <rostedt@goodmis.org>,
        Michal Kubecek <mkubecek@suse.cz>
Subject: Re: [PATCH v8 2/5] usb: early: add driver for xhci debug capability
Message-ID: <20170601122551.3x6p3g2jofvwi7gk@hirez.programming.kicks-ass.net>
References: <1490083293-3792-1-git-send-email-baolu.lu@linux.intel.com>
 <1490083293-3792-3-git-send-email-baolu.lu@linux.intel.com>
 <d5bbe767-4f80-fe70-dd2c-9b06c3ddda0d@gmail.com>
 <592E3817.4030402@linux.intel.com>
 <baf09de3-bff9-0afb-bd97-757c18a141e7@suse.cz>
 <592F8BF3.4070004@linux.intel.com>
 <56601eff-386e-3405-abf2-51a163201253@suse.cz>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <56601eff-386e-3405-abf2-51a163201253@suse.cz>
User-Agent: NeoMutt/20170113 (1.7.2)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 719
Lines: 13

On Thu, Jun 01, 2017 at 10:15:24AM +0200, Vlastimil Babka wrote:
> Thanks. I didn't make it clear that the trace_printk() warning is there
> even if the code using it doesn't actually execute (i.e. I didn't
> specify any early_printk bootparam). There are some roastedy tricks to
> detect the potential users, so that the buffers can be allocated in
> advance to allow the first trace_printk() from any context, I guess.
> 
> I'm not sure if there's a way to change it so that your driver reports
> the trace_printk usage only in response to the bootparam (which could
> also be a safe point to allocate ftrace buffers?).

No, nor do we want to. There should not be a single caller to
trace_printk() in normal kernels.