Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751241AbdFAMfQ (ORCPT ); Thu, 1 Jun 2017 08:35:16 -0400 Received: from verein.lst.de ([213.95.11.211]:46173 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751090AbdFAMfO (ORCPT ); Thu, 1 Jun 2017 08:35:14 -0400 Date: Thu, 1 Jun 2017 14:35:13 +0200 From: Christoph Hellwig To: Rakesh Pandit Cc: Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, Jens Axboe , Keith Busch , Andy Lutomirski Subject: Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Message-ID: <20170601123513.GA28067@lst.de> References: <20170530071610.GA2679@hercules.tuxera.com> <4da7c939-1f54-80e5-48fc-06e58e14f018@grimberg.me> <20170530142346.GA39428@dhcp-216.srv.tuxera.com> <20170601114338.GA24855@lst.de> <20170601122818.GA18830@dhcp-216.srv.tuxera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170601122818.GA18830@dhcp-216.srv.tuxera.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 685 Lines: 15 On Thu, Jun 01, 2017 at 03:28:18PM +0300, Rakesh Pandit wrote: > > I think we need the NVME_CTRL_SCHED_RESET state. In fact I'm pretty > > sure some time in the past I already had it in a local tree as a > > generalization of rdma and loop already use NVME_CTRL_RESETTING > > (they set it before queueing the reset work). > > > > But I don't fully understand how the NVME_CTRL_SCHED_RESET fix is > > related to this patch? > > They aren't related. Sorry for confusion. I intended to answer > another thread but instead wrote it here. Ok, thanks. But I think the Point from Sagi that we should move the state check all the way down to submit_sync_command still makes sense to me.