Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751204AbdFAMqe (ORCPT ); Thu, 1 Jun 2017 08:46:34 -0400 Received: from verein.lst.de ([213.95.11.211]:46243 "EHLO newverein.lst.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750952AbdFAMqd (ORCPT ); Thu, 1 Jun 2017 08:46:33 -0400 Date: Thu, 1 Jun 2017 14:46:32 +0200 From: Christoph Hellwig To: Rakesh Pandit Cc: Christoph Hellwig , Keith Busch , Sagi Grimberg , linux-kernel@vger.kernel.org, linux-nvme@lists.infradead.org, Jens Axboe , Andy Lutomirski Subject: Re: [PATCH V2] nvme: fix nvme_remove going to uninterruptible sleep for ever Message-ID: <20170601124631.GA28652@lst.de> References: <20170530071610.GA2679@hercules.tuxera.com> <4da7c939-1f54-80e5-48fc-06e58e14f018@grimberg.me> <20170530142346.GA39428@dhcp-216.srv.tuxera.com> <20170601114338.GA24855@lst.de> <20170601122818.GA18830@dhcp-216.srv.tuxera.com> <20170601123650.GA18883@dhcp-216.srv.tuxera.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20170601123650.GA18883@dhcp-216.srv.tuxera.com> User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 552 Lines: 11 On Thu, Jun 01, 2017 at 03:36:50PM +0300, Rakesh Pandit wrote: > Also Sagi pointed out that user space set_features ioctl if fired up > in a window after nvme_removal it can also result in this issue seems > to be correct. I would prefer to keep this as it is and introduce > similar check higher up in nvme_ioctrl instead so that we don't send > sync commands if queues are killed already. > > Would you prefer a patch ? Thanks, If we want to kill everyone we probably should do it in ->queue_rq. Or is the block layer blocking you somewhere else?