Subject: Re: [LINUX PATCH] usb: xhci: Add toggle cycle bit for the last seg
 trb when cached ring is used
To: Anurag Kumar Vulisha <anurag.kumar.vulisha@xilinx.com>,
        mathias.nyman@intel.com, gregkh@linuxfoundation.org
References: <1496238110-4998-1-git-send-email-anuragku@xilinx.com>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
        anirudh@xilinx.com, Anurag Kumar Vulisha <anuragku@xilinx.com>
From: Mathias Nyman <mathias.nyman@linux.intel.com>
Message-ID: <593014A0.9010509@linux.intel.com>
Date: Thu, 1 Jun 2017 16:20:32 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:38.0) Gecko/20100101
 Thunderbird/38.8.0
MIME-Version: 1.0
In-Reply-To: <1496238110-4998-1-git-send-email-anuragku@xilinx.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1055
Lines: 26

On 31.05.2017 16:41, Anurag Kumar Vulisha wrote:
> At present USB 2.0 cameras fail to play when run for 2nd time or greater.
> This issue occurs only when previous endpoint cached ring is used instead
> of allocating a new endpoint ring. The root cause of the problem narrows
> down to the Toggle bit, which is not getting set on the last trb of the
> cached ring last segment. When the controller fetches the last link trb
> with no toggle bit set, abnormal behaviour is generated.
> This patch solves that problem by adding the TOGGLE bit for the last trb
> of the last segment of the cached ring.
>
> Signed-off-by: Anurag Kumar Vulisha <anuragku@xilinx.com>

Thanks, nice catch.

I'm thinking about removing the whole endpoint ring caching instead.

We are using more memory by caching the rings instead of freeing them,
especially as we always try to allocate a new ring and only use the cached
ones when we fail to allocate a new ring.

Would you be willing to test a patch that removes the ring cache completely
with your setup?

Thanks
Mathias