Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751188AbdFAPP4 (ORCPT ); Thu, 1 Jun 2017 11:15:56 -0400 Received: from mail-it0-f44.google.com ([209.85.214.44]:38874 "EHLO mail-it0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751058AbdFAPPy (ORCPT ); Thu, 1 Jun 2017 11:15:54 -0400 MIME-Version: 1.0 In-Reply-To: <20170601151003.GB10526@rei.suse.de> References: <20170601140048.GA24401@rei.lan> <20170601143141.GB24401@rei.lan> <20170601151003.GB10526@rei.suse.de> From: Soheil Hassas Yeganeh Date: Thu, 1 Jun 2017 11:15:12 -0400 Message-ID: Subject: Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping To: Cyril Hrubis Cc: "David S. Miller" , Shmulik Ladkani , Marcelo Ricardo Leitner , Pravin B Shelar , Eric Dumazet , WANG Cong , Yaogong Wang , Steffen Klassert , Al Viro , netdev , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1003 Lines: 23 On Thu, Jun 1, 2017 at 11:10 AM, Cyril Hrubis wrote: >> Thank you for the confirmation. Could you please try the following >> patch to see if it fixes your issue? > > Does not seem to help, I still got the same bussy loop. Thank you for trying the patch. Unfortunately, I can't reproduce on my machines here.Would you humor me with another one? Thank you! diff --git a/net/core/skbuff.c b/net/core/skbuff.c index 5a726161f4e4..49207298fcea 100644 --- a/net/core/skbuff.c +++ b/net/core/skbuff.c @@ -3742,7 +3742,8 @@ EXPORT_SYMBOL(sock_queue_err_skb); static bool is_icmp_err_skb(const struct sk_buff *skb) { return skb && (SKB_EXT_ERR(skb)->ee.ee_origin == SO_EE_ORIGIN_ICMP || - SKB_EXT_ERR(skb)->ee.ee_origin == SO_EE_ORIGIN_ICMP6); + SKB_EXT_ERR(skb)->ee.ee_origin == SO_EE_ORIGIN_ICMP6 || + SKB_EXT_ERR(skb)->ee.ee_origin == SO_EE_ORIGIN_LOCAL); } struct sk_buff *sock_dequeue_err_skb(struct sock *sk)