Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751241AbdFAPgu (ORCPT ); Thu, 1 Jun 2017 11:36:50 -0400 Received: from mx2.suse.de ([195.135.220.15]:48571 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751078AbdFAPgt (ORCPT ); Thu, 1 Jun 2017 11:36:49 -0400 Date: Thu, 1 Jun 2017 17:36:45 +0200 From: Cyril Hrubis To: Soheil Hassas Yeganeh Cc: "David S. Miller" , Shmulik Ladkani , Marcelo Ricardo Leitner , Pravin B Shelar , Eric Dumazet , WANG Cong , Yaogong Wang , Steffen Klassert , Al Viro , netdev , linux-kernel@vger.kernel.org Subject: Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping Message-ID: <20170601153645.GC10526@rei.suse.de> References: <20170601140048.GA24401@rei.lan> <20170601143141.GB24401@rei.lan> <20170601151003.GB10526@rei.suse.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 678 Lines: 23 Hi! > >> Thank you for the confirmation. Could you please try the following > >> patch to see if it fixes your issue? > > > > Does not seem to help, I still got the same bussy loop. > > Thank you for trying the patch. Unfortunately, I can't reproduce on my > machines here.Would you humor me with another one? Thank you! Still does not help. I've modified the ping binary (on the top of you patch that reads the error queue) to dump the error structure. It seems to repeatedly produce (until I plug the cable back): ee_errno = 113 ee_origin = 2 ee_type = 3 ee_code = 1 ee_info = 0 ee_data = 0 So we get EHOSTUNREACH on SO_EE_ORIGIN_ICMP. -- Cyril Hrubis chrubis@suse.cz